[pbs-devel] [PATCH proxmox-backup 1/2] client: benchmark: fix indentation issues in api schema

[pbs-devel] [PATCH proxmox-backup 1/2] client: benchmark: fix indentation issues in api schema

[Christian Ebner]

This was noticed while extending the current schema.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 proxmox-backup-client/src/benchmark.rs | 32 +++++++++++++-------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/proxmox-backup-client/src/benchmark.rs b/proxmox-backup-client/src/benchmark.rs
index 463c2e61e..73e4f93fa 100644
--- a/proxmox-backup-client/src/benchmark.rs
+++ b/proxmox-backup-client/src/benchmark.rs
@@ -103,22 +103,22 @@ static BENCHMARK_RESULT_2020_TOP: BenchmarkResult = BenchmarkResult {
 };
 
 #[api(
-   input: {
-       properties: {
-           repository: {
-               schema: REPO_URL_SCHEMA,
-               optional: true,
-           },
-           keyfile: {
-               schema: KEYFILE_SCHEMA,
-               optional: true,
-           },
-           "output-format": {
-               schema: OUTPUT_FORMAT,
-               optional: true,
-           },
-       }
-   }
+    input: {
+        properties: {
+            repository: {
+                schema: REPO_URL_SCHEMA,
+                optional: true,
+            },
+            keyfile: {
+                schema: KEYFILE_SCHEMA,
+                optional: true,
+            },
+            "output-format": {
+                schema: OUTPUT_FORMAT,
+                optional: true,
+            },
+        },
+    },
 )]
 /// Run benchmark tests
 pub async fn benchmark(
-- 
2.47.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox-backup 2/2] client: benchmark: fix no-cache flag backwards comaptibility

[Christian Ebner]

The proxmox-backup-client benchmark command did unconditionally set
the no-cache flag to true. This is however not backwards compatible,
so expose it as additional cli flag instead, so the user can enable
it when benchmarking S3 backend, but default to false.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 proxmox-backup-client/src/benchmark.rs | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/proxmox-backup-client/src/benchmark.rs b/proxmox-backup-client/src/benchmark.rs
index 73e4f93fa..ad8c60ed9 100644
--- a/proxmox-backup-client/src/benchmark.rs
+++ b/proxmox-backup-client/src/benchmark.rs
@@ -113,6 +113,12 @@ static BENCHMARK_RESULT_2020_TOP: BenchmarkResult = BenchmarkResult {
                 schema: KEYFILE_SCHEMA,
                 optional: true,
             },
+            "no-cache": {
+                type: Boolean,
+                description: "Bypass local datastore cache for network storages.",
+                optional: true,
+                default: false,
+            },
             "output-format": {
                 schema: OUTPUT_FORMAT,
                 optional: true,
@@ -123,6 +129,7 @@ static BENCHMARK_RESULT_2020_TOP: BenchmarkResult = BenchmarkResult {
 /// Run benchmark tests
 pub async fn benchmark(
     param: Value,
+    no_cache: bool,
     _info: &ApiMethod,
     _rpcenv: &mut dyn RpcEnvironment,
 ) -> Result<(), Error> {
@@ -145,7 +152,7 @@ pub async fn benchmark(
 
     // do repo tests first, because this may prompt for a password
     if let Some(repo) = repo {
-        test_upload_speed(&mut benchmark_result, repo, crypt_config.clone()).await?;
+        test_upload_speed(&mut benchmark_result, repo, crypt_config.clone(), no_cache).await?;
     }
 
     test_crypt_speed(&mut benchmark_result)?;
@@ -221,6 +228,7 @@ async fn test_upload_speed(
     benchmark_result: &mut BenchmarkResult,
     repo: BackupRepository,
     crypt_config: Option<Arc<CryptConfig>>,
+    no_cache: bool,
 ) -> Result<(), Error> {
     let backup_time = proxmox_time::epoch_i64();
 
@@ -237,7 +245,7 @@ async fn test_upload_speed(
             crypt_config: crypt_config.clone(),
             debug: false,
             benchmark: true,
-            no_cache: true,
+            no_cache,
         },
     )
     .await?;
-- 
2.47.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup 2/2] client: benchmark: fix no-cache flag backwards comaptibility

[Christian Ebner]

On 7/24/25 11:01 AM, Christian Ebner wrote:
> The proxmox-backup-client benchmark command did unconditionally set
> the no-cache flag to true. This is however not backwards compatible,
> so expose it as additional cli flag instead, so the user can enable
> it when benchmarking S3 backend, but default to false.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>

I forgot, this should include:

Repoted-by: Dominik Csapak <d.csapak@proxmox.com>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox-backup 1/2] client: benchmark: fix indentation issues in api schema

[Thomas Lamprecht]

On Thu, 24 Jul 2025 11:00:38 +0200, Christian Ebner wrote:
> This was noticed while extending the current schema.
> 
> 

Applied, thanks!

[1/2] client: benchmark: fix indentation issues in api schema
      commit: 665e7296179dde6a74f4b36ff3e82f17b1cddabf
[2/2] client: benchmark: fix no-cache flag backwards comaptibility
      commit: 795b3f8ee176989edc86ef94a3e708f2e75e4de0


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel