[pbs-devel] [PATCH proxmox-backup 5/6] ui: default for s3 overwrite-in-use to be disabled

[Christian Ebner <c.ebner@proxmox.com>]

The flag only makes sense in combination with the reuse-existing
datastore flag, which is unchecked by default. Therefore, opt for the
overwrite-in-use flag to be disabled if unchecked and hidden if not
an s3 datastore.

Reported-by: Lukas Wagner <l.wagner@proxmox.com>
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 www/window/DataStoreEdit.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/www/window/DataStoreEdit.js b/www/window/DataStoreEdit.js
index 24ef3563e..9552cb05e 100644
--- a/www/window/DataStoreEdit.js
+++ b/www/window/DataStoreEdit.js
@@ -78,6 +78,8 @@ Ext.define('PBS.DataStoreEdit', {
                                 let s3ClientSelector = inputPanel.down('[name=s3client]');
                                 let overwriteInUseField =
                                     inputPanel.down('[name=overwrite-in-use]');
+                                let reuseDatastore =
+                                    inputPanel.down('[name=reuse-datastore]').getValue();
 
                                 uuidEditField.setDisabled(!isRemovable);
                                 uuidEditField.allowBlank = !isRemovable;
@@ -92,7 +94,7 @@ Ext.define('PBS.DataStoreEdit', {
                                 s3ClientSelector.setValue('');
 
                                 overwriteInUseField.setHidden(!isS3);
-                                overwriteInUseField.setDisabled(!isS3);
+                                overwriteInUseField.setDisabled(!reuseDatastore);
                                 overwriteInUseField.setValue(false);
 
                                 if (isRemovable) {
@@ -198,6 +200,8 @@ Ext.define('PBS.DataStoreEdit', {
                         xtype: 'checkbox',
                         name: 'overwrite-in-use',
                         fieldLabel: gettext('Overwrite in-use marker'),
+                        hidden: true,
+                        disabled: true,
                     },
                 ],
 
-- 
2.47.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel