public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 3/6] cli: use `endpoint` over `client` for s3 endpoint subcommands
Date: Tue, 22 Jul 2025 14:48:34 +0200	[thread overview]
Message-ID: <20250722124837.864242-4-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250722124837.864242-1-c.ebner@proxmox.com>

In order to be consistent with the UI and thereby reduce possible
confusion, where the naming was changed form `client` to `endpoint`
as well.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/bin/proxmox_backup_manager/s3.rs | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/bin/proxmox_backup_manager/s3.rs b/src/bin/proxmox_backup_manager/s3.rs
index 82bc9413a..867bc8e6b 100644
--- a/src/bin/proxmox_backup_manager/s3.rs
+++ b/src/bin/proxmox_backup_manager/s3.rs
@@ -10,7 +10,7 @@ use serde_json::Value;
 #[api(
     input: {
         properties: {
-            "s3-client-id": {
+            "s3-endpoint-id": {
                 schema: S3_CLIENT_ID_SCHEMA,
             },
             bucket: {
@@ -25,12 +25,12 @@ use serde_json::Value;
 )]
 /// Perform basic sanity checks for given S3 client configuration
 async fn check(
-    s3_client_id: String,
+    s3_endpoint_id: String,
     bucket: String,
     store_prefix: String,
     rpcenv: &mut dyn RpcEnvironment,
 ) -> Result<Value, Error> {
-    api2::admin::s3::check(s3_client_id, bucket, store_prefix, rpcenv).await?;
+    api2::admin::s3::check(s3_endpoint_id, bucket, store_prefix, rpcenv).await?;
     Ok(Value::Null)
 }
 
@@ -69,7 +69,7 @@ fn list_s3_clients(param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result<Valu
 }
 
 pub fn s3_commands() -> CommandLineInterface {
-    let client_cmd_def = CliCommandMap::new()
+    let endpoint_cmd_def = CliCommandMap::new()
         .insert("list", CliCommand::new(&API_METHOD_LIST_S3_CLIENTS))
         .insert(
             "create",
@@ -93,10 +93,10 @@ pub fn s3_commands() -> CommandLineInterface {
         .insert(
             "check",
             CliCommand::new(&API_METHOD_CHECK)
-                .arg_param(&["s3-client-id", "bucket"])
-                .completion_cb("s3-client-id", pbs_config::s3::complete_s3_client_id),
+                .arg_param(&["s3-endpoint-id", "bucket"])
+                .completion_cb("s3-endpoint-id", pbs_config::s3::complete_s3_client_id),
         )
-        .insert("client", client_cmd_def);
+        .insert("endpoint", endpoint_cmd_def);
 
     cmd_def.into()
 }
-- 
2.47.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  parent reply	other threads:[~2025-07-22 12:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22 12:48 [pbs-devel] [PATCH proxmox-backup 0/6] fix various s3 related ui/cli/doc issues Christian Ebner
2025-07-22 12:48 ` [pbs-devel] [PATCH proxmox-backup 1/6] ui: add tabs for remotes and move s3 endpoint config to it Christian Ebner
2025-07-22 12:48 ` [pbs-devel] [PATCH proxmox-backup 2/6] ui: use S3 endpoint over S3 client for ui elements Christian Ebner
2025-07-22 12:48 ` Christian Ebner [this message]
2025-07-22 12:48 ` [pbs-devel] [PATCH proxmox-backup 4/6] docs: use `endpoint` over `client` for the s3 endpoint configuration Christian Ebner
2025-07-22 12:48 ` [pbs-devel] [PATCH proxmox-backup 5/6] ui: default for s3 overwrite-in-use to be disabled Christian Ebner
2025-07-22 12:48 ` [pbs-devel] [PATCH proxmox-backup 6/6] ui: s3 client edit: allow for https scheme prefix in endpoint input Christian Ebner
2025-07-22 20:25 ` [pbs-devel] applied: [PATCH proxmox-backup 0/6] fix various s3 related ui/cli/doc issues Thomas Lamprecht
2025-07-23  6:33   ` Christian Ebner
2025-07-23  7:27     ` Thomas Lamprecht
2025-07-23  7:37       ` Christian Ebner
2025-07-23  7:55         ` Thomas Lamprecht
2025-07-23 10:04           ` Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250722124837.864242-4-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal