From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/6] ui: use S3 endpoint over S3 client for ui elements
Date: Tue, 22 Jul 2025 14:48:33 +0200 [thread overview]
Message-ID: <20250722124837.864242-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250722124837.864242-1-c.ebner@proxmox.com>
To distinguish the actual client from the endpoint configuration,
refer to the endpoint configuration and secrets as `S3 Endpoint`.
Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
www/config/S3ClientView.js | 2 +-
www/form/S3ClientSelector.js | 2 +-
www/window/S3ClientEdit.js | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/config/S3ClientView.js b/www/config/S3ClientView.js
index 9129fd948..d2e5b1efc 100644
--- a/www/config/S3ClientView.js
+++ b/www/config/S3ClientView.js
@@ -105,7 +105,7 @@ Ext.define('PBS.config.S3ClientView', {
columns: [
{
dataIndex: 'id',
- header: gettext('S3 Client ID'),
+ header: gettext('S3 Endpoint ID'),
renderer: Ext.String.htmlEncode,
sortable: true,
width: 200,
diff --git a/www/form/S3ClientSelector.js b/www/form/S3ClientSelector.js
index 243484909..44581d3df 100644
--- a/www/form/S3ClientSelector.js
+++ b/www/form/S3ClientSelector.js
@@ -16,7 +16,7 @@ Ext.define('PBS.form.S3ClientSelector', {
listConfig: {
columns: [
{
- header: gettext('S3 Client ID'),
+ header: gettext('S3 Endpoint ID'),
sortable: true,
dataIndex: 'id',
renderer: Ext.String.htmlEncode,
diff --git a/www/window/S3ClientEdit.js b/www/window/S3ClientEdit.js
index 932495e56..12d0b020d 100644
--- a/www/window/S3ClientEdit.js
+++ b/www/window/S3ClientEdit.js
@@ -32,7 +32,7 @@ Ext.define('PBS.window.S3ClientEdit', {
{
xtype: 'pmxDisplayEditField',
name: 'id',
- fieldLabel: gettext('S3 Client ID'),
+ fieldLabel: gettext('S3 Endpoint ID'),
renderer: Ext.htmlEncode,
allowBlank: false,
minLength: 4,
--
2.47.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-07-22 12:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 12:48 [pbs-devel] [PATCH proxmox-backup 0/6] fix various s3 related ui/cli/doc issues Christian Ebner
2025-07-22 12:48 ` [pbs-devel] [PATCH proxmox-backup 1/6] ui: add tabs for remotes and move s3 endpoint config to it Christian Ebner
2025-07-22 12:48 ` Christian Ebner [this message]
2025-07-22 12:48 ` [pbs-devel] [PATCH proxmox-backup 3/6] cli: use `endpoint` over `client` for s3 endpoint subcommands Christian Ebner
2025-07-22 12:48 ` [pbs-devel] [PATCH proxmox-backup 4/6] docs: use `endpoint` over `client` for the s3 endpoint configuration Christian Ebner
2025-07-22 12:48 ` [pbs-devel] [PATCH proxmox-backup 5/6] ui: default for s3 overwrite-in-use to be disabled Christian Ebner
2025-07-22 12:48 ` [pbs-devel] [PATCH proxmox-backup 6/6] ui: s3 client edit: allow for https scheme prefix in endpoint input Christian Ebner
2025-07-22 20:25 ` [pbs-devel] applied: [PATCH proxmox-backup 0/6] fix various s3 related ui/cli/doc issues Thomas Lamprecht
2025-07-23 6:33 ` Christian Ebner
2025-07-23 7:27 ` Thomas Lamprecht
2025-07-23 7:37 ` Christian Ebner
2025-07-23 7:55 ` Thomas Lamprecht
2025-07-23 10:04 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250722124837.864242-3-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox