From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v5 5/7] ui: add run-on-mount checkbox to SyncJob form
Date: Mon, 21 Jul 2025 13:33:12 +0200 [thread overview]
Message-ID: <20250721113314.59342-7-h.laimer@proxmox.com> (raw)
In-Reply-To: <20250721113314.59342-1-h.laimer@proxmox.com>
Exposes the `run-on-mount` flag in the advanced options of the sync job
edit window, allowing to set or clear it from the corresponding config.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
www/window/SyncJobEdit.js | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
index 0daae9ba..f430db0a 100644
--- a/www/window/SyncJobEdit.js
+++ b/www/window/SyncJobEdit.js
@@ -121,6 +121,7 @@ Ext.define('PBS.window.SyncJobEdit', {
values.id = 's-' + Ext.data.identifier.Uuid.Global.generate().slice(0, 13);
}
if (!me.isCreate) {
+ PBS.Utils.delete_if_default(values, 'run-on-mount', false);
PBS.Utils.delete_if_default(values, 'rate-in');
PBS.Utils.delete_if_default(values, 'rate-out');
PBS.Utils.delete_if_default(values, 'remote');
@@ -205,7 +206,7 @@ Ext.define('PBS.window.SyncJobEdit', {
xtype: 'pbsCalendarEvent',
name: 'schedule',
fieldLabel: gettext('Sync Schedule'),
- emptyText: gettext('none (disabled)'),
+ emptyText: gettext('none'),
cbind: {
deleteEmpty: '{!isCreate}',
value: '{scheduleValue}',
@@ -488,6 +489,19 @@ Ext.define('PBS.window.SyncJobEdit', {
uncheckedValue: false,
value: false,
},
+ {
+ xtype: 'proxmoxcheckbox',
+ name: 'run-on-mount',
+ fieldLabel: gettext('Run when mounted'),
+ autoEl: {
+ tag: 'div',
+ 'data-qtip': gettext(
+ 'Run this job when a relevant removable datastore is mounted.',
+ ),
+ },
+ uncheckedValue: false,
+ value: false,
+ },
],
},
{
--
2.47.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-07-21 11:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 11:33 [pbs-devel] [PATCH proxmox{, -backup} v5 0/8] trigger sync jobs on mount Hannes Laimer
2025-07-21 11:33 ` [pbs-devel] [PATCH proxmox v5 1/1] pbs-api-types: add run-on-mount flag to SyncJobConfig Hannes Laimer
2025-07-22 14:40 ` [pbs-devel] applied: " Thomas Lamprecht
2025-07-21 11:33 ` [pbs-devel] [PATCH proxmox-backup v5 1/7] api: config: sync: update run-on-mount correctly Hannes Laimer
2025-07-21 11:33 ` [pbs-devel] [PATCH proxmox-backup v5 2/7] api: admin: run configured sync jobs when a datastore is mounted Hannes Laimer
2025-07-21 11:33 ` [pbs-devel] [PATCH proxmox-backup v5 3/7] api: admin: trigger sync jobs only on datastore mount Hannes Laimer
2025-07-21 11:33 ` [pbs-devel] [PATCH proxmox-backup v5 4/7] bin: manager: run uuid_mount/mount tasks on the proxy Hannes Laimer
2025-07-21 11:33 ` Hannes Laimer [this message]
2025-07-21 11:33 ` [pbs-devel] [PATCH proxmox-backup v5 6/7] ui: add task title for triggering sync jobs Hannes Laimer
2025-07-21 11:33 ` [pbs-devel] [PATCH proxmox-backup v5 7/7] docs: add section about `run-on-mount` sync job flag Hannes Laimer
2025-07-22 17:08 ` [pbs-devel] [PATCH proxmox{, -backup} v5 0/8] trigger sync jobs on mount Christian Ebner
2025-07-22 20:14 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250721113314.59342-7-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox