public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v5 1/7] api: config: sync: update run-on-mount correctly
Date: Mon, 21 Jul 2025 13:33:08 +0200	[thread overview]
Message-ID: <20250721113314.59342-3-h.laimer@proxmox.com> (raw)
In-Reply-To: <20250721113314.59342-1-h.laimer@proxmox.com>

Sets or clears the run-on-mount flag in sync job configs, removing the
optional value from the config if requested for deletion via the api call.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 src/api2/config/sync.rs | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/api2/config/sync.rs b/src/api2/config/sync.rs
index 6194d865..358409b5 100644
--- a/src/api2/config/sync.rs
+++ b/src/api2/config/sync.rs
@@ -339,6 +339,8 @@ pub enum DeletableProperty {
     EncryptedOnly,
     /// Delete the verified_only property,
     VerifiedOnly,
+    /// Delete the run_on_mount property,
+    RunOnMount,
     /// Delete the sync_direction property,
     SyncDirection,
 }
@@ -458,6 +460,9 @@ pub fn update_sync_job(
                 DeletableProperty::VerifiedOnly => {
                     data.verified_only = None;
                 }
+                DeletableProperty::RunOnMount => {
+                    data.run_on_mount = None;
+                }
                 DeletableProperty::SyncDirection => {
                     data.sync_direction = None;
                 }
@@ -507,6 +512,9 @@ pub fn update_sync_job(
     if let Some(verified_only) = update.verified_only {
         data.verified_only = Some(verified_only);
     }
+    if let Some(run_on_mount) = update.run_on_mount {
+        data.run_on_mount = Some(run_on_mount);
+    }
     if let Some(sync_direction) = update.sync_direction {
         data.sync_direction = Some(sync_direction);
     }
@@ -683,6 +691,7 @@ acl:1:/remote/remote1/remotestore1:write@pbs:RemoteSyncOperator
         transfer_last: None,
         encrypted_only: None,
         verified_only: None,
+        run_on_mount: None,
         sync_direction: None, // use default
     };
 
-- 
2.47.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  parent reply	other threads:[~2025-07-21 11:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-21 11:33 [pbs-devel] [PATCH proxmox{, -backup} v5 0/8] trigger sync jobs on mount Hannes Laimer
2025-07-21 11:33 ` [pbs-devel] [PATCH proxmox v5 1/1] pbs-api-types: add run-on-mount flag to SyncJobConfig Hannes Laimer
2025-07-22 14:40   ` [pbs-devel] applied: " Thomas Lamprecht
2025-07-21 11:33 ` Hannes Laimer [this message]
2025-07-21 11:33 ` [pbs-devel] [PATCH proxmox-backup v5 2/7] api: admin: run configured sync jobs when a datastore is mounted Hannes Laimer
2025-07-21 11:33 ` [pbs-devel] [PATCH proxmox-backup v5 3/7] api: admin: trigger sync jobs only on datastore mount Hannes Laimer
2025-07-21 11:33 ` [pbs-devel] [PATCH proxmox-backup v5 4/7] bin: manager: run uuid_mount/mount tasks on the proxy Hannes Laimer
2025-07-21 11:33 ` [pbs-devel] [PATCH proxmox-backup v5 5/7] ui: add run-on-mount checkbox to SyncJob form Hannes Laimer
2025-07-21 11:33 ` [pbs-devel] [PATCH proxmox-backup v5 6/7] ui: add task title for triggering sync jobs Hannes Laimer
2025-07-21 11:33 ` [pbs-devel] [PATCH proxmox-backup v5 7/7] docs: add section about `run-on-mount` sync job flag Hannes Laimer
2025-07-22 17:08 ` [pbs-devel] [PATCH proxmox{, -backup} v5 0/8] trigger sync jobs on mount Christian Ebner
2025-07-22 20:14 ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250721113314.59342-3-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal