[pbs-devel] [PATCH proxmox 1/1] pbs-api-types: change default notification mode to 'notification-system'

[Lukas Wagner <l.wagner@proxmox.com>]

The former default was chose avoid breaking changes during a minor
release, but with the upcoming major release we can change the default.

The rationale for the new default is:
  - 'notification-system' was already used as a default for any datastore
    created by the GUI
  - consistency, since on PVE, the default is 'auto' (which does not exist
    on PBS, but is equivalent to 'notification-system' unless an email
    address has been added as well)
  - users are gently nudged to use the new notification stack

The new default affects any datastore/tape backup job that has no
explicit value set. On the PBS side some migration code will be added to
d/postinst to migrate users who relied on the old default to the
appropriate explicit setting.

As mentioned above, the GUI already explicitly set the value to the new
default for a long time. As a result, this mostly affects newly created
datastores/tape jobs from the CLI/API.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 pbs-api-types/src/datastore.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
index 5bd953ac..ecbeed8e 100644
--- a/pbs-api-types/src/datastore.rs
+++ b/pbs-api-types/src/datastore.rs
@@ -402,9 +402,9 @@ pub struct DataStoreConfig {
 pub enum NotificationMode {
     /// Send notifications via the system's sendmail command to the user
     /// configured in `notify-user`
-    #[default]
     LegacySendmail,
     /// Emit notification events to the notification system
+    #[default]
     NotificationSystem,
 }
 
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel