[pbs-devel] [PATCH proxmox-backup v4 29/45] datastore: get and set owner for S3 store backend

[Christian Ebner <c.ebner@proxmox.com>]

Read or write the ownership information from/to the corresponding
object in the S3 object store. Keep that information available if
the bucket is reused as datastore.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 pbs-datastore/src/datastore.rs | 39 ++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
index a11161995..ea429983f 100644
--- a/pbs-datastore/src/datastore.rs
+++ b/pbs-datastore/src/datastore.rs
@@ -7,6 +7,7 @@ use std::sync::{Arc, LazyLock, Mutex};
 use std::time::Duration;
 
 use anyhow::{bail, format_err, Context, Error};
+use http_body_util::BodyExt;
 use nix::unistd::{unlinkat, UnlinkatFlags};
 use pbs_s3_client::{PutObjectResponse, S3Client, S3ClientOptions};
 use pbs_tools::lru_cache::LruCache;
@@ -839,6 +840,24 @@ impl DataStore {
         backup_group: &pbs_api_types::BackupGroup,
     ) -> Result<Authid, Error> {
         let full_path = self.owner_path(ns, backup_group);
+
+        if let DatastoreBackend::S3(s3_client) = self.backend()? {
+            let object_key = format!(
+                "{}/{backup_group}/owner",
+                ns.path()
+                    .to_str()
+                    .ok_or_else(|| format_err!("unexpected owner path"))?,
+            );
+            let response =
+                proxmox_async::runtime::block_on(s3_client.get_object(object_key.as_str().into()))?
+                    .ok_or_else(|| format_err!("fetching owner failed"))?;
+            let content = proxmox_async::runtime::block_on(response.content.collect())?;
+            let owner = String::from_utf8(content.to_bytes().trim_ascii_end().to_vec())?;
+            return owner
+                .parse()
+                .map_err(|err| format_err!("parsing owner for {backup_group} failed: {err}"));
+        }
+
         let owner = proxmox_sys::fs::file_read_firstline(full_path)?;
         owner
             .trim_end() // remove trailing newline
@@ -867,6 +886,26 @@ impl DataStore {
     ) -> Result<(), Error> {
         let path = self.owner_path(ns, backup_group);
 
+        if let DatastoreBackend::S3(s3_client) = self.backend()? {
+            let object_key = format!(
+                "{}/{backup_group}/owner",
+                ns.path()
+                    .to_str()
+                    .ok_or_else(|| format_err!("unexpected owner path"))?,
+            );
+            let data = proxmox_http::Body::from(format!("{auth_id}\n"));
+            let response = proxmox_async::runtime::block_on(
+                s3_client.put_object(object_key.as_str().into(), data),
+            )?;
+            match response {
+                PutObjectResponse::NeedsRetry => bail!("failed to set owner, needs retry"),
+                PutObjectResponse::PreconditionFailed => {
+                    bail!("failed to set owner, precondition failed")
+                }
+                PutObjectResponse::Success(_) => (),
+            }
+        }
+
         let mut open_options = std::fs::OpenOptions::new();
         open_options.write(true);
 
-- 
2.47.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel