[pbs-devel] [RFC proxmox-backup 24/39] api: remove snapshot from S3 backend on snapshot delete

[Christian Ebner <c.ebner@proxmox.com>]

Prune the snapshot from the S3 object store followed by removing the
contents from the local cache store.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/api2/admin/datastore.rs | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs
index 7b7f79b22..45204369a 100644
--- a/src/api2/admin/datastore.rs
+++ b/src/api2/admin/datastore.rs
@@ -63,8 +63,9 @@ use pbs_datastore::manifest::BackupManifest;
 use pbs_datastore::prune::compute_prune_info;
 use pbs_datastore::{
     check_backup_owner, ensure_datastore_is_mounted, task_tracking, BackupDir, BackupGroup,
-    DataStore, LocalChunkReader, StoreProgress,
+    DataStore, DatastoreBackend, LocalChunkReader, StoreProgress,
 };
+use pbs_s3_client::S3_CONTENT_PREFIX;
 use pbs_tools::json::required_string_param;
 use proxmox_rest_server::{formatter, WorkerTask};
 
@@ -432,6 +433,20 @@ pub async fn delete_snapshot(
 
         let snapshot = datastore.backup_dir(ns, backup_dir)?;
 
+        // TODO: How to handle locking for consistency?
+        if let DatastoreBackend::S3(s3_client) = datastore.backend()? {
+            let path = snapshot.relative_path();
+            let snapshot_prefix = path
+                .to_str()
+                .ok_or_else(|| format_err!("invalid snapshot path prefix"))?;
+            let prefix = format!("{S3_CONTENT_PREFIX}/{snapshot_prefix}");
+            let delete_object_result =
+                proxmox_async::runtime::block_on(s3_client.delete_objects_by_prefix(&prefix))?;
+            if delete_object_result.error.is_some() {
+                bail!("deleting objects failed");
+            }
+        }
+
         snapshot.destroy(false)?;
 
         Ok(Value::Null)
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel