From: Gabriel Goller <g.goller@proxmox.com>
To: pbs-devel@lists.proxmox.com
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: [pbs-devel] [PATCH proxmox-backup] rest-server: increase max body size
Date: Tue, 8 Apr 2025 15:26:26 +0200 [thread overview]
Message-ID: <20250408132626.381476-1-g.goller@proxmox.com> (raw)
Increase maximum POST request body size from 64KB to 512KB to match the value
used in pve-http-server. This change addresses potential limitations with the
newly introduced consent-banner feature, which can contain lots of text
that could approach the previous limits.
The patch to pve-http-server:
Link: https://git.proxmox.com/?p=pve-http-server.git;a=commit;h=2650923a42c9ea357dc0e663a69294410190cc7c
Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Link: https://lore.proxmox.com/pbs-devel/e0cfec76-5149-4d3d-80be-b96ae633e1ee@proxmox.com/
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
proxmox-rest-server/src/rest.rs | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/proxmox-rest-server/src/rest.rs b/proxmox-rest-server/src/rest.rs
index f5a72052b888..98e8268fcfba 100644
--- a/proxmox-rest-server/src/rest.rs
+++ b/proxmox-rest-server/src/rest.rs
@@ -405,8 +405,7 @@ async fn get_request_parameters<S: 'static + BuildHasher + Send>(
http_err!(BAD_REQUEST, "Problems reading request body: {}", err)
})
.try_fold(Vec::new(), |mut acc, chunk| async move {
- // FIXME: max request body size?
- if acc.len() + chunk.len() < 64 * 1024 {
+ if acc.len() + chunk.len() < 512 * 1024 {
acc.extend_from_slice(&chunk);
Ok(acc)
} else {
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2025-04-08 13:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 13:26 Gabriel Goller [this message]
2025-04-08 15:04 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408132626.381476-1-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal