public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 10/10] notifications: remove HTML template for test notification
Date: Fri, 21 Mar 2025 13:25:21 +0100	[thread overview]
Message-ID: <20250321122521.198725-11-l.wagner@proxmox.com> (raw)
In-Reply-To: <20250321122521.198725-1-l.wagner@proxmox.com>

The template files for this one have simply been copied from PVE, including
the HTML template.
In PBS we actually don't provide any HTML templates for any other type
of notification, so especially with the template override mechanism on
the horizon, it's probably better to remove this template until we also
provide an HTML version for the other types as well.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 debian/proxmox-backup-server.install | 1 -
 templates/Makefile                   | 1 -
 templates/default/test-body.html.hbs | 1 -
 templates/default/test-body.txt.hbs  | 2 +-
 4 files changed, 1 insertion(+), 4 deletions(-)
 delete mode 100644 templates/default/test-body.html.hbs

diff --git a/debian/proxmox-backup-server.install b/debian/proxmox-backup-server.install
index a562d5e8..45f8d903 100644
--- a/debian/proxmox-backup-server.install
+++ b/debian/proxmox-backup-server.install
@@ -63,7 +63,6 @@ usr/share/proxmox-backup/templates/default/tape-backup-ok-body.txt.hbs
 usr/share/proxmox-backup/templates/default/tape-backup-ok-subject.txt.hbs
 usr/share/proxmox-backup/templates/default/tape-load-body.txt.hbs
 usr/share/proxmox-backup/templates/default/tape-load-subject.txt.hbs
-usr/share/proxmox-backup/templates/default/test-body.html.hbs
 usr/share/proxmox-backup/templates/default/test-body.txt.hbs
 usr/share/proxmox-backup/templates/default/test-subject.txt.hbs
 usr/share/proxmox-backup/templates/default/verify-err-body.txt.hbs
diff --git a/templates/Makefile b/templates/Makefile
index 0f8ad72c..0539902e 100644
--- a/templates/Makefile
+++ b/templates/Makefile
@@ -24,7 +24,6 @@ NOTIFICATION_TEMPLATES=						\
 	default/tape-load-body.txt.hbs			\
 	default/tape-load-subject.txt.hbs		\
 	default/test-body.txt.hbs				\
-	default/test-body.html.hbs				\
 	default/test-subject.txt.hbs			\
 	default/verify-err-body.txt.hbs			\
 	default/verify-ok-body.txt.hbs			\
diff --git a/templates/default/test-body.html.hbs b/templates/default/test-body.html.hbs
deleted file mode 100644
index 26a43dde..00000000
--- a/templates/default/test-body.html.hbs
+++ /dev/null
@@ -1 +0,0 @@
-This is a test of the notification target '{{ target }}'.
diff --git a/templates/default/test-body.txt.hbs b/templates/default/test-body.txt.hbs
index 26a43dde..24454433 100644
--- a/templates/default/test-body.txt.hbs
+++ b/templates/default/test-body.txt.hbs
@@ -1 +1 @@
-This is a test of the notification target '{{ target }}'.
+This is a test of the notification target '{{target}}'.
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  parent reply	other threads:[~2025-03-21 12:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-21 12:25 [pbs-devel] [PATCH proxmox-backup 00/10] notifications: cleanup in preparation of overridable templates Lukas Wagner
2025-03-21 12:25 ` [pbs-devel] [PATCH proxmox-backup 01/10] notifications: move make notifications module a dir-style module Lukas Wagner
2025-03-21 12:25 ` [pbs-devel] [PATCH proxmox-backup 02/10] notifications: add type for GC notification template data Lukas Wagner
2025-03-21 13:28   ` Wolfgang Bumiller
2025-03-24  8:32     ` Lukas Wagner
2025-03-21 12:25 ` [pbs-devel] [PATCH proxmox-backup 03/10] notifications: add type for ACME " Lukas Wagner
2025-03-21 12:25 ` [pbs-devel] [PATCH proxmox-backup 04/10] notifications: add type for APT " Lukas Wagner
2025-03-24 10:39   ` Lukas Wagner
2025-03-21 12:25 ` [pbs-devel] [PATCH proxmox-backup 05/10] notifications: add type for prune " Lukas Wagner
2025-03-21 12:25 ` [pbs-devel] [PATCH proxmox-backup 06/10] notifications: add type for sync " Lukas Wagner
2025-03-21 12:25 ` [pbs-devel] [PATCH proxmox-backup 07/10] notifications: add type for tape backup " Lukas Wagner
2025-03-21 12:25 ` [pbs-devel] [PATCH proxmox-backup 08/10] notifications: add type for tape load " Lukas Wagner
2025-03-21 12:25 ` [pbs-devel] [PATCH proxmox-backup 09/10] notifications: add type for verify " Lukas Wagner
2025-03-21 12:25 ` Lukas Wagner [this message]
2025-03-21 12:38 ` [pbs-devel] [PATCH proxmox-backup 00/10] notifications: cleanup in preparation of overridable templates Maximiliano Sandoval
2025-03-27 14:57 ` [pbs-devel] superseded: " Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250321122521.198725-11-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal