From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v7 proxmox 2/10] pbs api types: add garbage collection atime safety check flag
Date: Thu, 20 Mar 2025 14:17:03 +0100 [thread overview]
Message-ID: <20250320131711.312894-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250320131711.312894-1-c.ebner@proxmox.com>
Add the `gc-atime-safety-check` flag to the datastore tuning
parameters. This flag allows to enable/disable a check to detect if
the atime update is honored by the filesystem backing the chunk store
during phase 1 of garbage collection and during datastore creation.
The default is to perform the check.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
changes since version 6:
- no changes
pbs-api-types/src/datastore.rs | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
index ddd8d3c6..1a4d9e2d 100644
--- a/pbs-api-types/src/datastore.rs
+++ b/pbs-api-types/src/datastore.rs
@@ -229,6 +229,14 @@ pub enum DatastoreFSyncLevel {
type: ChunkOrder,
optional: true,
},
+ "gc-atime-safety-check": {
+ description:
+ "Check filesystem atime updates are honored during store creation and garbage \
+ collection",
+ optional: true,
+ default: true,
+ type: bool,
+ },
},
)]
#[derive(Serialize, Deserialize, Default)]
@@ -240,6 +248,8 @@ pub struct DatastoreTuning {
pub chunk_order: Option<ChunkOrder>,
#[serde(skip_serializing_if = "Option::is_none")]
pub sync_level: Option<DatastoreFSyncLevel>,
+ #[serde(skip_serializing_if = "Option::is_none")]
+ pub gc_atime_safety_check: Option<bool>,
}
pub const DATASTORE_TUNING_STRING_SCHEMA: Schema = StringSchema::new("Datastore tuning options")
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-03-20 13:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 13:17 [pbs-devel] [PATCH v7 proxmox proxmox-backup 00/10] fix #5982: check atime update is honored Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox 1/10] worker task: include anyhow error context in state error message Christian Ebner
2025-03-20 13:46 ` [pbs-devel] applied: " Wolfgang Bumiller
2025-03-20 13:17 ` Christian Ebner [this message]
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox 3/3] pbs api types: add option to set GC chunk cleanup atime cutoff Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 04/10] garbage collection: format error including anyhow error context Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 05/10] fix #5982: garbage collection: check atime updates are honored Christian Ebner
2025-03-20 14:59 ` Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 06/10] ui: expose GC atime safety check flag in datastore tuning options Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 07/10] docs: mention GC atime update check for " Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 08/10] datastore: use custom GC atime cutoff if set Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 09/10] ui: expose GC atime cutoff in datastore tuning option Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 10/10] docs: mention gc-atime-cutoff as " Christian Ebner
2025-03-21 8:04 ` [pbs-devel] [PATCH v7 proxmox proxmox-backup 00/10] fix #5982: check atime update is honored Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250320131711.312894-3-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal