From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v7 proxmox-backup 09/10] ui: expose GC atime cutoff in datastore tuning option
Date: Thu, 20 Mar 2025 14:17:10 +0100 [thread overview]
Message-ID: <20250320131711.312894-10-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250320131711.312894-1-c.ebner@proxmox.com>
Allows to set the atime cutoff for phase 2 of garbage collection in
the datastores tuning parameters. This value changes the time after
which a chunk is not considered in use anymore if it falls outside of
the cutoff window.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
changes since version 6:
- no changes
www/Utils.js | 5 +++++
www/datastore/OptionView.js | 11 +++++++++++
2 files changed, 16 insertions(+)
diff --git a/www/Utils.js b/www/Utils.js
index 9bd7e1615..13b5eceda 100644
--- a/www/Utils.js
+++ b/www/Utils.js
@@ -850,6 +850,11 @@ Ext.define('PBS.Utils', {
delete tuning['gc-atime-safety-check'];
options.push(`${gettext('GC Access Time Safety Check')}: ${gc_atime_safety_check ?? true}`);
+ let gc_atime_cutoff = tuning['gc-atime-cutoff'];
+ delete tuning['gc-atime-cutoff'];
+ gc_atime_cutoff = gc_atime_cutoff ?? '1445';
+ options.push(`${gettext('GC Access Time Cutoff')}: ${gc_atime_cutoff}m`);
+
for (const [k, v] of Object.entries(tuning)) {
options.push(`${k}: ${v}`);
}
diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
index eb846ab76..f29574169 100644
--- a/www/datastore/OptionView.js
+++ b/www/datastore/OptionView.js
@@ -283,6 +283,17 @@ Ext.define('PBS.Datastore.Options', {
uncheckedValue: 0,
deleteDefaultValue: true,
},
+ {
+ xtype: 'proxmoxintegerfield',
+ name: 'gc-atime-cutoff',
+ emptyText: gettext('1445 (24 hours 5 minutes)'),
+ fieldLabel: gettext('GC atime Cutoff'),
+ autoEl: {
+ tag: 'div',
+ 'data-qtip': gettext('Cutoff for atime in minutes'),
+ },
+ deleteEmpty: true,
+ },
],
},
},
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-03-20 13:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 13:17 [pbs-devel] [PATCH v7 proxmox proxmox-backup 00/10] fix #5982: check atime update is honored Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox 1/10] worker task: include anyhow error context in state error message Christian Ebner
2025-03-20 13:46 ` [pbs-devel] applied: " Wolfgang Bumiller
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox 2/10] pbs api types: add garbage collection atime safety check flag Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox 3/3] pbs api types: add option to set GC chunk cleanup atime cutoff Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 04/10] garbage collection: format error including anyhow error context Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 05/10] fix #5982: garbage collection: check atime updates are honored Christian Ebner
2025-03-20 14:59 ` Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 06/10] ui: expose GC atime safety check flag in datastore tuning options Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 07/10] docs: mention GC atime update check for " Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 08/10] datastore: use custom GC atime cutoff if set Christian Ebner
2025-03-20 13:17 ` Christian Ebner [this message]
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 10/10] docs: mention gc-atime-cutoff as datastore tuning option Christian Ebner
2025-03-21 8:04 ` [pbs-devel] [PATCH v7 proxmox proxmox-backup 00/10] fix #5982: check atime update is honored Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250320131711.312894-10-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal