From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v3 proxmox proxmox-backup 0/7] fix #4182: concurrent group pull/push support for sync jobs
Date: Tue, 18 Mar 2025 13:24:16 +0100 [thread overview]
Message-ID: <20250318122423.385684-1-c.ebner@proxmox.com> (raw)
Syncing contents from/to a remote source via a sync job suffers from
low throughput on high latency networks because of limitations by the
HTTP/2 connection, as described in [0]. To improve, syncing multiple
groups in parallel by establishing multiple reader instances has been
suggested.
This patch series implements the functionality by adding the sync job
configuration property `parallel-groups`, allowing to define the
number of concurrent groups pull/push futures to be instantiated and
executed for each job.
The property is currently not exposed on the UI, as intended to be
set in the config directly for now.
Examplary configuration:
```
sync: s-8764c440-3a6c
ns
owner root@pam
remote local
remote-ns
remote-store push-target-store
remove-vanished false
store datastore
sync-direction push
parallel-groups 4
```
Since log messages are now also written concurrently, prefix logs
related to groups, snapshots and archives with their respective
context prefix and add context to error messages.
Further, improve logging especially for sync jobs in push direction,
which only displayed limited information so far.
[0] https://bugzilla.proxmox.com/show_bug.cgi?id=4182
proxmox:
Christian Ebner (1):
pbs api types: add 'parallel-groups' to sync job config
pbs-api-types/src/jobs.rs | 14 ++++++++++++++
1 file changed, 14 insertions(+)
proxmox-backup:
Christian Ebner (6):
client: backup writer: fix upload stats size and rate for push sync
api: config/sync: add optional `parallel-groups` property
fix #4182: server: sync: allow pulling groups concurrently
server: pull: prefix log messages and add error context
server: sync: allow pushing groups concurrently
server: push: prefix log messages and add additional logging
pbs-client/src/backup_stats.rs | 20 +--
pbs-client/src/backup_writer.rs | 4 +-
pbs-datastore/src/store_progress.rs | 2 +-
src/api2/config/sync.rs | 10 ++
src/api2/pull.rs | 9 +-
src/api2/push.rs | 9 +-
src/server/pull.rs | 217 +++++++++++++++++-----------
src/server/push.rs | 147 ++++++++++++++-----
src/server/sync.rs | 10 +-
9 files changed, 292 insertions(+), 136 deletions(-)
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2025-03-18 12:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 12:24 Christian Ebner [this message]
2025-03-18 12:24 ` [pbs-devel] [PATCH v3 proxmox 1/7] pbs api types: add 'parallel-groups' to sync job config Christian Ebner
2025-03-18 12:24 ` [pbs-devel] [PATCH v3 proxmox-backup 2/7] client: backup writer: fix upload stats size and rate for push sync Christian Ebner
2025-03-18 12:24 ` [pbs-devel] [PATCH v3 proxmox-backup 3/7] api: config/sync: add optional `parallel-groups` property Christian Ebner
2025-03-18 12:24 ` [pbs-devel] [PATCH v3 proxmox-backup 4/7] fix #4182: server: sync: allow pulling groups concurrently Christian Ebner
2025-03-18 12:24 ` [pbs-devel] [PATCH v3 proxmox-backup 5/7] server: pull: prefix log messages and add error context Christian Ebner
2025-03-18 12:24 ` [pbs-devel] [PATCH v3 proxmox-backup 6/7] server: sync: allow pushing groups concurrently Christian Ebner
2025-03-18 12:24 ` [pbs-devel] [PATCH v3 proxmox-backup 7/7] server: push: prefix log messages and add additional logging Christian Ebner
2025-04-04 13:51 ` [pbs-devel] superseded: [PATCH v3 proxmox proxmox-backup 0/7] fix #4182: concurrent group pull/push support for sync jobs Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250318122423.385684-1-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal