public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH backup 6/8] create a CachedSchema struct
Date: Thu,  6 Mar 2025 14:12:33 +0100	[thread overview]
Message-ID: <20250306131235.452521-6-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20250306131235.452521-1-m.sandoval@proxmox.com>

Fix the type_complexity clippy lint.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/api2/config/acme.rs | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/src/api2/config/acme.rs b/src/api2/config/acme.rs
index 422b9720..99832d1d 100644
--- a/src/api2/config/acme.rs
+++ b/src/api2/config/acme.rs
@@ -428,9 +428,13 @@ impl Serialize for ChallengeSchemaWrapper {
     }
 }
 
+struct CachedSchema {
+    schema: Arc<Vec<AcmeChallengeSchema>>,
+    cached_mtime: SystemTime,
+}
+
 fn get_cached_challenge_schemas() -> Result<ChallengeSchemaWrapper, Error> {
-    static CACHE: LazyLock<Mutex<Option<(Arc<Vec<AcmeChallengeSchema>>, SystemTime)>>> =
-        LazyLock::new(|| Mutex::new(None));
+    static CACHE: LazyLock<Mutex<Option<CachedSchema>>> = LazyLock::new(|| Mutex::new(None));
 
     // the actual loading code
     let mut last = CACHE.lock().unwrap();
@@ -438,10 +442,16 @@ fn get_cached_challenge_schemas() -> Result<ChallengeSchemaWrapper, Error> {
     let actual_mtime = fs::metadata(crate::config::acme::ACME_DNS_SCHEMA_FN)?.modified()?;
 
     let schema = match &*last {
-        Some((schema, cached_mtime)) if *cached_mtime >= actual_mtime => schema.clone(),
+        Some(CachedSchema {
+            schema,
+            cached_mtime,
+        }) if *cached_mtime >= actual_mtime => schema.clone(),
         _ => {
             let new_schema = Arc::new(crate::config::acme::load_dns_challenge_schema()?);
-            *last = Some((Arc::clone(&new_schema), actual_mtime));
+            *last = Some(CachedSchema {
+                schema: Arc::clone(&new_schema),
+                cached_mtime: actual_mtime,
+            });
             new_schema
         }
     };
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  parent reply	other threads:[~2025-03-06 13:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06 13:12 [pbs-devel] [PATCH backup 1/8] server: remove needless clone Maximiliano Sandoval
2025-03-06 13:12 ` [pbs-devel] [PATCH backup 2/8] run cargo clippy --fix Maximiliano Sandoval
2025-03-06 13:12 ` [pbs-devel] [PATCH backup 3/8] api: remove redundant guard Maximiliano Sandoval
2025-03-06 13:12 ` [pbs-devel] [PATCH backup 4/8] snapshot_reader: replace Arc with Rc Maximiliano Sandoval
2025-03-06 13:12 ` [pbs-devel] [PATCH backup 5/8] fix the type_complexity clippy lint Maximiliano Sandoval
2025-03-06 13:12 ` Maximiliano Sandoval [this message]
2025-03-06 13:12 ` [pbs-devel] [PATCH backup 7/8] zfs: remove unnecessary arc from dataset object map Maximiliano Sandoval
2025-03-06 13:12 ` [pbs-devel] [PATCH backup 8/8] add too_many_arguments clippy exception Maximiliano Sandoval
2025-03-06 14:00 ` [pbs-devel] applied-series: [PATCH backup 1/8] server: remove needless clone Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250306131235.452521-6-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal