From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH backup v2] fix #3336: cleanup when deleting last snapshot
Date: Thu, 6 Mar 2025 13:48:32 +0100 [thread overview]
Message-ID: <20250306124832.416170-1-m.sandoval@proxmox.com> (raw)
When the last snapshot from a group is deleted we clear the entire
group, this in turn cleans the owner for the group.
Without this change, the user is unable to change the owner of the group
after the last snapshot has been deleted. This would prevent a new
backups to the same group from a different owner.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Differences from v1:
- Use BackupGroup::destroy directly, which prevents some clones
src/api2/admin/datastore.rs | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs
index dbb7ae47..6853d268 100644
--- a/src/api2/admin/datastore.rs
+++ b/src/api2/admin/datastore.rs
@@ -427,6 +427,16 @@ pub async fn delete_snapshot(
snapshot.destroy(false)?;
+ let group = BackupGroup::from(snapshot);
+ if group.list_backups().is_ok_and(|backups| backups.is_empty()) {
+ if let Err(err) = group.destroy() {
+ log::error!(
+ "error while cleaning group {path:?} - {err}",
+ path = group.full_group_path()
+ );
+ }
+ }
+
Ok(Value::Null)
})
.await?
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
reply other threads:[~2025-03-06 12:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306124832.416170-1-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal