From: Shannon Sterz <s.sterz@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox 00/19] clippy, test and doc clean up
Date: Thu, 6 Mar 2025 13:43:30 +0100 [thread overview]
Message-ID: <20250306124349.288370-1-s.sterz@proxmox.com> (raw)
this series intends to clean up all clippy lints for all crates in the
proxmox repo. it also makes sure all non-ignored test cases work again
(some recent changes broke some test cases) and cleans up all warnings
that were produced when running `cargo doc`.
Shannon Sterz (19):
io: clippy fix: replace `map()` followed by `any()` with just `any()`
tree-wide: add parantheses to clarify precedence
tree-wide: remove clone calls on types that are `Copy`
tfa: don't use block in conditions
tfa: remove needless `as_bytes` call
access-control/tfa: use `?` instead of unnecessary match statements
sys: add truncate option to `OpenOptions` in test case
router: allow `from_str` on Confirmation that is not for `FromStr`
auth-api/tfa: prefer `Display` over `ToString`/an inherent function
acme/auth-api: add `Default` for types with un-parameterized `new()`
shared-memory: specify generic types for transmute
router: ignore clippy lint `missing_transmute_annotations`
rest-server/router: ignore type complexity clippy lint
apt: ignore clippy lint about using a slice reference instead of
`&Vec`
apt: ignore clippy lint about new having to return `Self`
network-api: ignore clippy lint about upper case acronyms
router: fix nested doc test cases to match inteded output
api-macro: re-order ObjectSchema fields to be sorted
tree-wide: fix intra doc links
proxmox-access-control/src/acl.rs | 25 +++++++------------
proxmox-acme-api/src/challenge_schemas.rs | 1 +
proxmox-acme/src/async_client.rs | 2 +-
proxmox-acme/src/types.rs | 6 +++++
proxmox-api-macro/src/lib.rs | 13 +++++-----
proxmox-apt/src/cache.rs | 1 +
proxmox-apt/src/repositories/file.rs | 1 +
proxmox-auth-api/src/auth_key.rs | 6 +++++
proxmox-auth-api/src/ticket.rs | 9 ++++---
proxmox-client/src/client.rs | 2 +-
proxmox-compression/src/zip.rs | 2 +-
proxmox-io/src/sparse_copy.rs | 3 +--
proxmox-log/src/file_logger.rs | 3 +--
proxmox-network-api/src/config/lexer.rs | 1 +
.../examples/minimal-rest-server.rs | 1 +
proxmox-rest-server/src/api_config.rs | 4 +--
proxmox-rest-server/src/worker_task.rs | 14 +++--------
proxmox-router/src/cli/mod.rs | 1 +
proxmox-router/src/router.rs | 1 +
proxmox-router/src/stream/parsing.rs | 1 +
proxmox-router/tests/docs.rs | 3 +++
proxmox-rrd/src/cache.rs | 8 ++----
proxmox-rrd/src/cache/journal.rs | 18 +++----------
proxmox-rrd/src/cache/rrd_map.rs | 6 ++---
proxmox-schema/src/upid.rs | 2 +-
proxmox-shared-cache/src/lib.rs | 18 +++----------
proxmox-shared-memory/src/lib.rs | 2 +-
proxmox-sys/src/logrotate.rs | 2 +-
proxmox-sys/src/systemd.rs | 2 +-
proxmox-sys/tests/xattr.rs | 1 +
proxmox-systemd/src/escape.rs | 2 +-
proxmox-tfa/src/api/methods.rs | 23 +++++++++--------
proxmox-tfa/src/api/webauthn.rs | 10 +++++---
proxmox-tfa/src/totp.rs | 2 +-
proxmox-uuid/src/lib.rs | 12 ++++-----
35 files changed, 99 insertions(+), 109 deletions(-)
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2025-03-06 12:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 12:43 Shannon Sterz [this message]
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 01/19] io: clippy fix: replace `map()` followed by `any()` with just `any()` Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 02/19] tree-wide: add parantheses to clarify precedence Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 03/19] tree-wide: remove clone calls on types that are `Copy` Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 04/19] tfa: don't use block in conditions Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 05/19] tfa: remove needless `as_bytes` call Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 06/19] access-control/tfa: use `?` instead of unnecessary match statements Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 07/19] sys: add truncate option to `OpenOptions` in test case Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 08/19] router: allow `from_str` on Confirmation that is not for `FromStr` Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 09/19] auth-api/tfa: prefer `Display` over `ToString`/an inherent function Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 10/19] acme/auth-api: add `Default` for types with un-parameterized `new()` Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 11/19] shared-memory: specify generic types for transmute Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 12/19] router: ignore clippy lint `missing_transmute_annotations` Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 13/19] rest-server/router: ignore type complexity clippy lint Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 14/19] apt: ignore clippy lint about using a slice reference instead of `&Vec` Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 15/19] apt: ignore clippy lint about new having to return `Self` Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 16/19] network-api: ignore clippy lint about upper case acronyms Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 17/19] router: fix nested doc test cases to match inteded output Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 18/19] api-macro: re-order ObjectSchema fields to be sorted Shannon Sterz
2025-03-06 12:43 ` [pbs-devel] [PATCH proxmox 19/19] tree-wide: fix intra doc links Shannon Sterz
2025-03-06 14:26 ` [pbs-devel] applied-series: [PATCH proxmox 00/19] clippy, test and doc clean up Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306124349.288370-1-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal