[pbs-devel] [PATCH proxmox proxmox-backup 0/2] fix #5892: check atime update is honored

[Christian Ebner <c.ebner@proxmox.com>]

These patches add a check to phase 1 of garbage collection in order
to detect when the filesystem backing the chunk store does not honor
atime updates. This avoids possible data loss for situations where
garbage collection could otherwise delete chunks still referenced by
a backup snaphost's index file.

In order to reduce overhead and since filesystem mounted with
relatime are not guaranteed to update the atime each time, only check
the first chunk for which the atime is outside of the grace period
range and skip for all latter. Since finding this first chunk also
has an overhead (stating all chunks pre-atime update), allow to
disable this checks altogether by setting a datastore tuning
parameter flag.

Link to the issue in the bugtracker:
https://bugzilla.proxmox.com/show_bug.cgi?id=5982

proxmox:

Christian Ebner (1):
  pbs api types: Add check garbage collection atime updates flag

 pbs-api-types/src/datastore.rs | 8 ++++++++
 1 file changed, 8 insertions(+)

proxmox-backup:

Christian Ebner (1):
  fix #5982: garbage collection: check atime updates are honored

 pbs-datastore/src/datastore.rs | 50 +++++++++++++++++++++++++++++++---
 1 file changed, 46 insertions(+), 4 deletions(-)

-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel