[pbs-devel] [PATCH v3 proxmox-backup 0/5] handle reader client disconnects

[Christian Ebner <c.ebner@proxmox.com>]

These patches attempt to improve the server side error handling for
backukp reader client disconnects.

During regular operation, the server currently cannot distinguish a
disconnect because of error from a disconnect because of finished
operation. This leaves behind a task in failed state, which is
unexpected and might cause confusion [0].

To improve error handling, follow the approach taken for the backup
writer tasks, letting the client signal it has successfully finished
via an api call and catch the disconnect error for that case.

The signaling of messages/warnings in case of client side aborts
triggered by the user as suggested by Fabian has not been
implemented, as that is currently not transparently handled by the
client (only handled by BackupReader's Drop impl), therefore seemed
out of scope for this patch series.

Reported in the community forum:
[0] https://forum.proxmox.com/threads/158306/

Version 2 of the patches:
https://lore.proxmox.com/pbs-devel/20241204083149.58754-1-c.ebner@proxmox.com/T/

Christian Ebner (5):
  client: reader: drop dead code
  backup debug: diff: refactor backup reader creation
  api: reader: handle reader client disconnects
  client: reader: add finish method to signal client state to server
  client: backup reader: call finish before dropping backup readers

 examples/download-speed.rs           |  2 ++
 pbs-client/src/backup_reader.rs      | 10 +++---
 proxmox-backup-client/src/catalog.rs |  2 ++
 proxmox-backup-client/src/main.rs    |  7 ++++
 proxmox-backup-client/src/mount.rs   |  3 ++
 proxmox-file-restore/src/main.rs     | 19 +++++++---
 src/api2/reader/environment.rs       | 20 ++++++++++-
 src/api2/reader/mod.rs               | 27 +++++++++++---
 src/bin/proxmox_backup_debug/diff.rs | 53 +++++++++++++---------------
 src/server/pull.rs                   |  7 +++-
 src/server/push.rs                   |  2 +-
 src/server/sync.rs                   | 30 +++++++++-------
 12 files changed, 126 insertions(+), 56 deletions(-)

-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel