From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v2 proxmox-backup 0/3] handle reader client disconnects
Date: Wed, 4 Dec 2024 09:31:46 +0100 [thread overview]
Message-ID: <20241204083149.58754-1-c.ebner@proxmox.com> (raw)
These patches attempt to improve the server side error handling for
reader client disconnects.
During regular operation, the server currently cannot distinguish a
disconnect because of error from a disconnect because of finished
operation. This leaves behind a task in failed state, which is
unexpected and might cause confusion [0].
To improve error handling, follow the approach taken for the backup
writer tasks, letting the client signal it has successfully finished
via an api call and catch the disconnect error for that case.
Reported in the community forum:
[0] https://forum.proxmox.com/threads/158306/
Version 1 of the patches:
https://lore.proxmox.com/pbs-devel/20241203112756.63872-1-c.ebner@proxmox.com/T/
Christian Ebner (3):
client: backup: remove unnecessary clone for backup reader
api: reader: handle reader client disconnects
client: reader: signal server before client disconnect
pbs-client/src/backup_reader.rs | 2 ++
proxmox-backup-client/src/main.rs | 4 ++--
src/api2/reader/environment.rs | 20 +++++++++++++++++++-
src/api2/reader/mod.rs | 30 +++++++++++++++++++++++++++---
4 files changed, 50 insertions(+), 6 deletions(-)
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2024-12-04 8:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 8:31 Christian Ebner [this message]
2024-12-04 8:31 ` [pbs-devel] [PATCH v2 proxmox-backup 1/3] client: backup: remove unnecessary clone for backup reader Christian Ebner
2024-12-04 13:50 ` [pbs-devel] applied: " Fabian Grünbichler
2024-12-04 8:31 ` [pbs-devel] [PATCH v2 proxmox-backup 2/3] api: reader: handle reader client disconnects Christian Ebner
2024-12-04 8:31 ` [pbs-devel] [PATCH v2 proxmox-backup 3/3] client: reader: signal server before client disconnect Christian Ebner
2024-12-04 13:49 ` Fabian Grünbichler
2024-12-04 14:13 ` Christian Ebner
2024-12-05 9:40 ` Fabian Grünbichler
2024-12-05 9:56 ` Christian Ebner
2024-12-05 11:29 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241204083149.58754-1-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox