From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 3/3] client: reader: signal server before client disconnect
Date: Tue, 3 Dec 2024 12:27:56 +0100 [thread overview]
Message-ID: <20241203112756.63872-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20241203112756.63872-1-c.ebner@proxmox.com>
Signal the server that the client has successfully finished its
operation and is about to close the connection. This allows the server
side to react and clean up the connection gracefully, without
returning and logging an error state, as that can cause confusion [0],
as this is not an error but normal behaviour.
Report in the community forum:
[0] https://forum.proxmox.com/threads/158306/
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
pbs-client/src/backup_reader.rs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/pbs-client/src/backup_reader.rs b/pbs-client/src/backup_reader.rs
index 88cba599b..63106c999 100644
--- a/pbs-client/src/backup_reader.rs
+++ b/pbs-client/src/backup_reader.rs
@@ -27,6 +27,8 @@ pub struct BackupReader {
impl Drop for BackupReader {
fn drop(&mut self) {
+ // Ignore errors
+ let _ = proxmox_async::runtime::block_on(self.post("finish", None));
self.abort.abort();
}
}
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-12-03 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 11:27 [pbs-devel] [PATCH proxmox-backup 1/3] client: backup: remove unnecessary clone for backup writer Christian Ebner
2024-12-03 11:27 ` [pbs-devel] [PATCH proxmox-backup 2/3] api: reader: gracefully handle reader client disconnects Christian Ebner
2024-12-03 12:17 ` Christian Ebner
2024-12-03 11:27 ` Christian Ebner [this message]
2024-12-04 8:59 ` [pbs-devel] [PATCH proxmox-backup 1/3] client: backup: remove unnecessary clone for backup writer Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241203112756.63872-3-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox