From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH backup 07/13] remove needless type conversion
Date: Mon, 2 Dec 2024 10:58:02 +0100 [thread overview]
Message-ID: <20241202095808.128299-7-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20241202095808.128299-1-m.sandoval@proxmox.com>
The mount types were probably here for compatibility with older proxmox-sys.
Fixes the useless_conversion clippy lints:
```
warning: useless conversion to the same type: `std::os::fd::OwnedFd`
--> proxmox-backup-client/src/mount.rs:172:23
|
172 | let pr: OwnedFd = pr.into(); // until next sys bump
| ^^^^^^^^^ help: consider removing `.into()`: `pr`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
warning: useless conversion to the same type: `std::os::fd::OwnedFd`
--> proxmox-backup-client/src/mount.rs:173:23
|
173 | let pw: OwnedFd = pw.into();
| ^^^^^^^^^ help: consider removing `.into()`: `pw`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
warning: useless conversion to the same type: `pbs_api_types::BackupArchiveName`
--> proxmox-file-restore/src/main.rs:484:18
|
484 | &archive_name.try_into()?,
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider removing `.try_into()`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
```
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
proxmox-backup-client/src/mount.rs | 2 --
proxmox-file-restore/src/main.rs | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/proxmox-backup-client/src/mount.rs b/proxmox-backup-client/src/mount.rs
index 0048a8ad4..4929f5e5d 100644
--- a/proxmox-backup-client/src/mount.rs
+++ b/proxmox-backup-client/src/mount.rs
@@ -169,8 +169,6 @@ fn mount(
// Process should be daemonized.
// Make sure to fork before the async runtime is instantiated to avoid troubles.
let (pr, pw) = proxmox_sys::pipe()?;
- let pr: OwnedFd = pr.into(); // until next sys bump
- let pw: OwnedFd = pw.into();
match unsafe { fork() } {
Ok(ForkResult::Parent { .. }) => {
drop(pw);
diff --git a/proxmox-file-restore/src/main.rs b/proxmox-file-restore/src/main.rs
index bbfc6eb4e..59ccbe524 100644
--- a/proxmox-file-restore/src/main.rs
+++ b/proxmox-file-restore/src/main.rs
@@ -479,7 +479,7 @@ async fn extract(
let (archive_name, payload_archive_name) =
pbs_client::tools::get_pxar_archive_names(&archive_name, &manifest)?;
let (reader, archive_size) = get_remote_pxar_reader(
- &archive_name.try_into()?,
+ &archive_name,
client.clone(),
&manifest,
crypt_config.clone(),
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-12-02 9:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 9:57 [pbs-devel] [PATCH backup 01/13] remove needless borrows Maximiliano Sandoval
2024-12-02 9:57 ` [pbs-devel] [PATCH backup 02/13] use inspect_err when possible Maximiliano Sandoval
2024-12-02 9:57 ` [pbs-devel] [PATCH backup 03/13] backup_manager: use Vec::first instead of get(0) Maximiliano Sandoval
2024-12-02 9:57 ` [pbs-devel] [PATCH backup 04/13] push: use unwrap_or to prevent lazy evaluation Maximiliano Sandoval
2024-12-02 9:58 ` [pbs-devel] [PATCH backup 05/13] docs: use sublist indentation Maximiliano Sandoval
2024-12-02 9:58 ` [pbs-devel] [PATCH backup 06/13] client: remove unnecessary deref Maximiliano Sandoval
2024-12-02 9:58 ` Maximiliano Sandoval [this message]
2024-12-02 9:58 ` [pbs-devel] [PATCH backup 08/13] client: catalog: remove unnecessary sort_unstable_by Maximiliano Sandoval
2024-12-02 9:58 ` [pbs-devel] [PATCH backup 09/13] docs: fix outer docs comments Maximiliano Sandoval
2024-12-02 9:58 ` [pbs-devel] [PATCH backup 10/13] remove redundant imports Maximiliano Sandoval
2024-12-02 9:58 ` [pbs-devel] [PATCH backup 11/13] restore_daemon: use map_while instead of filter_map(Result::ok) Maximiliano Sandoval
2024-12-02 9:58 ` [pbs-devel] [PATCH backup 12/13] datastore: simplify let-else block with ? operator Maximiliano Sandoval
2024-12-02 9:58 ` [pbs-devel] [PATCH backup 13/13] api: config: run rustfmt Maximiliano Sandoval
2024-12-02 11:20 ` [pbs-devel] applied-series: [PATCH backup 01/13] remove needless borrows Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241202095808.128299-7-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox