public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH] ui: filter partitions without proper UUID in partition selector
@ 2024-11-27 15:17 Hannes Laimer
  2024-11-27 19:19 ` [pbs-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Hannes Laimer @ 2024-11-27 15:17 UTC (permalink / raw)
  To: pbs-devel

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 www/form/PartitionSelector.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/form/PartitionSelector.js b/www/form/PartitionSelector.js
index 162dbe418..7ef542ffb 100644
--- a/www/form/PartitionSelector.js
+++ b/www/form/PartitionSelector.js
@@ -8,7 +8,7 @@ Ext.define('pbs-partition-list', {
 	    transform: (rawData) => rawData.data
 		.flatMap(disk => (disk.partitions
 			.map(part => ({ ...part, model: disk.model })) ?? [])
-			.filter(partition => partition.used === 'filesystem')),
+			.filter(partition => partition.used === 'filesystem' && !!partition.uuid)),
 	},jj
     },
     idProperty: 'devpath',
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pbs-devel] applied: [PATCH] ui: filter partitions without proper UUID in partition selector
  2024-11-27 15:17 [pbs-devel] [PATCH] ui: filter partitions without proper UUID in partition selector Hannes Laimer
@ 2024-11-27 19:19 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-11-27 19:19 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Hannes Laimer

Am 27.11.24 um 16:17 schrieb Hannes Laimer:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>  www/form/PartitionSelector.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/form/PartitionSelector.js b/www/form/PartitionSelector.js
> index 162dbe418..7ef542ffb 100644
> --- a/www/form/PartitionSelector.js
> +++ b/www/form/PartitionSelector.js
> @@ -8,7 +8,7 @@ Ext.define('pbs-partition-list', {
>  	    transform: (rawData) => rawData.data
>  		.flatMap(disk => (disk.partitions
>  			.map(part => ({ ...part, model: disk.model })) ?? [])
> -			.filter(partition => partition.used === 'filesystem')),
> +			.filter(partition => partition.used === 'filesystem' && !!partition.uuid)),
>  	},jj

^-- git am spotted this mishap as:

error: patch failed: www/form/PartitionSelector.js:8      
error: www/form/PartitionSelector.js: patch does not apply
error: Did you hand edit your patch?                      

I fixed that up and applied the patch, one needs to take care when editing
a patch directly, ideally it's avoided.

>      },
>      idProperty: 'devpath',



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-27 19:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-27 15:17 [pbs-devel] [PATCH] ui: filter partitions without proper UUID in partition selector Hannes Laimer
2024-11-27 19:19 ` [pbs-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal