public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v2] kernel: enable codepage 437 for vfat support
Date: Tue, 26 Nov 2024 14:26:02 +0100	[thread overview]
Message-ID: <20241126132602.576027-1-s.ivanov@proxmox.com> (raw)

ran into an issue when clicking on the ESP of a VM while trying
single-file restore. Enabling the single option fixed the issue, and
got the partition successfully mounted.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
changes v1->v2:
* only enabled the single needed option, and put it in the block where
  the remaining NLS options were set already (overlooked that on the
  first attempt) - Thanks @Fabian for the feedback!

As the issue seems to have been around for around one year - I don't
think we need to rush applying it (and can do so when upgrading to a
new kernel+ZFS version)

 src/config-base | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/config-base b/src/config-base
index 1581b09..edd95c1 100644
--- a/src/config-base
+++ b/src/config-base
@@ -102,6 +102,7 @@ CONFIG_SYSFS=y
 CONFIG_NLS=y
 CONFIG_NLS_UTF8=y
 CONFIG_NLS_ISO8859_1=y
+CONFIG_NLS_CODEPAGE_437=y
 CONFIG_MSDOS_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_FILE_LOCKING=y
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


                 reply	other threads:[~2024-11-26 13:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241126132602.576027-1-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal