From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 4/4] api types: drop unused config type helpers for sync direction
Date: Mon, 25 Nov 2024 18:40:12 +0100 [thread overview]
Message-ID: <20241125174012.678523-5-c.ebner@proxmox.com> (raw)
In-Reply-To: <20241125174012.678523-1-c.ebner@proxmox.com>
Jobs for both sync directions are now stored using the same `sync`
config section type, so drop the outdated helpers.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
pbs-api-types/src/jobs.rs | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/pbs-api-types/src/jobs.rs b/pbs-api-types/src/jobs.rs
index 4a85378ce..16b16dd84 100644
--- a/pbs-api-types/src/jobs.rs
+++ b/pbs-api-types/src/jobs.rs
@@ -519,23 +519,6 @@ impl std::fmt::Display for SyncDirection {
}
}
-impl SyncDirection {
- pub fn as_config_type_str(&self) -> &'static str {
- match self {
- SyncDirection::Pull => "sync",
- SyncDirection::Push => "sync-push",
- }
- }
-
- pub fn from_config_type_str(config_type: &str) -> Result<Self, anyhow::Error> {
- match config_type {
- "sync" => Ok(SyncDirection::Pull),
- "sync-push" => Ok(SyncDirection::Push),
- _ => bail!("invalid config type for sync job"),
- }
- }
-}
-
pub const RESYNC_CORRUPT_SCHEMA: Schema =
BooleanSchema::new("If the verification failed for a local snapshot, try to pull it again.")
.schema();
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-25 17:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 17:40 [pbs-devel] [PATCH proxmox-backup 0/4] use same config section type for all sync jobs Christian Ebner
2024-11-25 17:40 ` [pbs-devel] [PATCH proxmox-backup 1/4] config: sync: use same config section type `sync` for push and pull Christian Ebner
2024-11-25 17:40 ` [pbs-devel] [PATCH proxmox-backup 2/4] api: admin/config: introduce sync direction as job config parameter Christian Ebner
2024-11-25 17:40 ` [pbs-devel] [PATCH proxmox-backup 3/4] bin: show direction in sync job list output Christian Ebner
2024-11-25 17:40 ` Christian Ebner [this message]
2024-11-26 9:20 ` [pbs-devel] [PATCH proxmox-backup] (List)SyncDirection: extract match check into impl fn Fabian Grünbichler
2024-11-26 9:21 ` [pbs-devel] [PATCH proxmox-backup 0/4] use same config section type for all sync jobs Fabian Grünbichler
2024-11-26 14:47 ` [pbs-devel] [PATCH proxmox-backup] sync jobs: remove superfluous direction property Dominik Csapak
2024-11-26 14:50 ` [pbs-devel] [PATCH proxmox-backup 0/4] use same config section type for all sync jobs Dominik Csapak
2024-11-26 15:04 ` [pbs-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241125174012.678523-5-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox