From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/2] sync: pull: mention why last snapshot of previous sync is resynced
Date: Mon, 4 Nov 2024 13:56:13 +0100 [thread overview]
Message-ID: <20241104125614.162491-1-c.ebner@proxmox.com> (raw)
The last snapshot synced during the previous sync job might not have
been fully completed just yet (e.g. backup log still missing,
verification still ongoing, ...).
Explicitley mention the reason and that the resync is therefore
intentional by a comment in the filter logic.
Suggested-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
changes since version 1:
- no present in previous version
src/server/pull.rs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/server/pull.rs b/src/server/pull.rs
index cc1427196..8d8461cb2 100644
--- a/src/server/pull.rs
+++ b/src/server/pull.rs
@@ -528,6 +528,8 @@ async fn pull_group(
.enumerate()
.filter(|&(pos, ref dir)| {
source_snapshots.insert(dir.time);
+ // Note: Last sync times final snapshot might not have been completely
+ // done yet on the source side, keep it include for a resync.
if last_sync_time > dir.time {
already_synced_skip_info.update(dir.time);
return false;
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2024-11-04 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 12:56 Christian Ebner [this message]
2024-11-04 12:56 ` [pbs-devel] [PATCH proxmox-backup 2/2] sync: pull: simplify logic for source snapshot filtering Christian Ebner
2024-11-04 14:14 ` [pbs-devel] applied-series: [PATCH proxmox-backup 1/2] sync: pull: mention why last snapshot of previous sync is resynced Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104125614.162491-1-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox