From: Gabriel Goller <g.goller@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 0/5] introduce dedcated archive name api type
Date: Thu, 24 Oct 2024 11:21:00 +0200 [thread overview]
Message-ID: <20241024092100.yu6cxafiwvkhsijz@luna.proxmox.com> (raw)
In-Reply-To: <20241024080150.30200-1-c.ebner@proxmox.com>
On 24.10.2024 10:01, Christian Ebner wrote:
>There is currently no dedicated api type for the archive names, given
>as input parameters to several api methods.
>
>This patches introduce a dedicated type for archive names, in order
>to collect the code for checks and eventual mappings into one
>location and reduce possible unintentional misuse by passing
>incorrect argument values to the functions and methods consuming
>the archive names.
>
>As a positive side effect, the mapping now allows also for the server
>archive type extensions to be optionally passed as input to several
>commands, e.g.
>```
>proxmox-backup-client restore <snapshot> <name>.pxar.didx <target>
>```
>is now valid, being equal to
>```
>proxmox-backup-client restore <snapshot> <name.pxar <target>
>```
>
>@Gabriel: Did not include your git trailers since there was some
>rebasing, please double check if the changes are still fine by you.
Not a thorough review, just a quick glance over the changes – which seem
fine. Also did a quick test with proxmox-backup-client
restore/mount.
Consider:
Tested-by: Gabriel Goller <g.goller@proxmox.com>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-10-24 9:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 8:01 Christian Ebner
2024-10-24 8:01 ` [pbs-devel] [PATCH v3 proxmox-backup 1/5] datastore: move `ArchiveType` to api types Christian Ebner
2024-10-24 8:01 ` [pbs-devel] [PATCH v3 proxmox-backup 2/5] api types: introduce `BackupArchiveName` type Christian Ebner
2024-10-25 12:15 ` Fabian Grünbichler
2024-11-04 11:56 ` Christian Ebner
2024-11-04 12:23 ` Fabian Grünbichler
2024-10-24 8:01 ` [pbs-devel] [PATCH v3 proxmox-backup 3/5] client/server: use dedicated api type for all archive names Christian Ebner
2024-10-24 8:01 ` [pbs-devel] [PATCH v3 proxmox-backup 4/5] client: drop unused parse_archive_type helper Christian Ebner
2024-10-24 8:01 ` [pbs-devel] [PATCH v3 proxmox-backup 5/5] api types: add unit tests for backup archive name parsing Christian Ebner
2024-10-24 9:21 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024092100.yu6cxafiwvkhsijz@luna.proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox