public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v2 proxmox proxmox-backup 0/5] backup client progress log interval
Date: Wed, 23 Oct 2024 11:10:58 +0200	[thread overview]
Message-ID: <20241023091103.80792-1-c.ebner@proxmox.com> (raw)

These patches allow to specify a time based or size based interval
for progress log output as generated during `proxmox-backup-client
backup` runs.

The client is extended by optional `progress-interval` and
`progress-size-interval` parameters, which allows to set the interval
either as `TimeSpan` or `HumanByte` parsable input string, depending
on the variant. The parameters are in conflict with each other, only
one of them might be set at the same time.
If none of the parameters is given, the default time based interval
of 1 minute is used.

Examples for client invocations are:
- no progress logging:
  `proxmox-backup-client backup root.pxar:/ --progress-interval=0`
- time based progress logging with 1min 30s interval
  `proxmox-backup-client backup root.pxar:/ --progress-interval="1m 30s"`
- size based progress logging with 512MiB interval
  `proxmox-backup-client backup root.pxar:/ --progress-size-interval=512MiB`

Lower limits are set to 1s and 100MiB for the corresponding variant in
order to prevent excessive log output. If values below the respective
limits are given, the progress log output is disabled.

Most notable changes since version 1 (thanks to Thomas for feedback):
- Split time and size based variants into separate options
- Disabling of log output is now handled by setting a value below the
  minimum.

proxmox:

Christian Ebner (2):
  time: fix typos in `TimeSpan` related docstring
  time: also implement `From<&TimeSpan> for f64`

 proxmox-time/src/time_span.rs | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

proxmox-backup:

Christian Ebner (3):
  api-types: client: add wrapper api type for TimeSpan
  client: progress log: factor out log message generation
  client: progress log: allow to specify backup log interval

 pbs-api-types/src/client.rs       |  49 ++++++++++++++
 pbs-api-types/src/lib.rs          |   3 +
 pbs-client/src/backup_writer.rs   | 104 +++++++++++++++++++++++++-----
 proxmox-backup-client/src/main.rs |  54 ++++++++++++++--
 4 files changed, 188 insertions(+), 22 deletions(-)
 create mode 100644 pbs-api-types/src/client.rs

-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


             reply	other threads:[~2024-10-23  9:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23  9:10 Christian Ebner [this message]
2024-10-23  9:10 ` [pbs-devel] [PATCH v2 proxmox 1/5] time: fix typos in `TimeSpan` related docstring Christian Ebner
2024-10-23  9:11 ` [pbs-devel] [PATCH v2 proxmox 2/5] time: also implement `From<&TimeSpan> for f64` Christian Ebner
2024-10-23  9:11 ` [pbs-devel] [PATCH v2 proxmox-backup 3/5] api-types: client: add wrapper api type for TimeSpan Christian Ebner
2024-10-23  9:11 ` [pbs-devel] [PATCH v2 proxmox-backup 4/5] client: progress log: factor out log message generation Christian Ebner
2024-10-23  9:11 ` [pbs-devel] [PATCH v2 proxmox-backup 5/5] client: progress log: allow to specify backup log interval Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241023091103.80792-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal