From: Gabriel Goller <g.goller@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [POC proxmox proxmox-backup 0/4] use custom DNS resolver for
Date: Tue, 8 Oct 2024 16:50:26 +0200 [thread overview]
Message-ID: <20241008145026.cclpx3xgdraau53i@luna.proxmox.com> (raw)
In-Reply-To: <20240928094256.153991-1-c.ebner@proxmox.com>
On 28.09.2024 11:42, Christian Ebner wrote:
>As discussed in issue #4788 [0], statically linking of the
>`proxmox-backup-client` still suffers from possible incompatible
>dependencies on the NSS module libraries, further described in
>[1].
>
>This proof of concept drafts a possible workaround by relying on
>`hickory-dns` [2], using the hickory-resolver for name resolution
>instead of the default `getaddrinfo` based `GaiResolver` used by
>the hyper http client, as suggested by Thomas.
>
>These patches still need some polishing, but allow already to compile
>a static binary without the glibc issues as descibied in the issue,
>therefore sending them for possible more widespread testing.
>
>Initial testing on ArchLinux with glic 2.40+r16+gaa533d58ff-2,
>previously leading to floating point exceptions, now allows to backup
>without issues using the patched client.
>
>A major downside is the required dependencies for hickory-dns`, as with
>the feature `system-config` enabled (used to read nameservers from
>`/etc/resolv.conf`), also the windows dependencies on `ipconfig` and
>it's subdependencies are required.
This would be a dealbreaker for us IMO, but luckily this has already
been fixed on the main branch!
The whole 'ipconfig' crate is an optional dependency and should only be
pulled in if the target is windows. This is already implemented in the
latest version [1], but it doesn't yet work quite right. This pull
request (already merged) [0], solves this by removes the implicit
features (which are created on a optional dependency automatically).
This means we either use the main branch for now, or wait until the next
version is released and we can remove ipconfig, widestring, windows-sys
and winreg!
[0]: https://github.com/hickory-dns/hickory-dns/pull/2337
[1]: https://github.com/hickory-dns/hickory-dns/blob/7887002d1198ed9faaaae531e0f9815c10589f7a/crates/resolver/Cargo.toml#L104
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-10-08 14:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-28 9:42 Christian Ebner
2024-09-28 9:42 ` [pbs-devel] [POC proxmox 1/4] http: client: make https connector generic over resolver Christian Ebner
2024-09-28 9:42 ` [pbs-devel] [POC proxmox-backup 2/4] Makefile: target for statically linked client binary Christian Ebner
2024-09-28 9:42 ` [pbs-devel] [POC proxmox-backup 3/4] Makefile: switch path based on build mode by using COMPILEDIR Christian Ebner
2024-09-28 9:42 ` [pbs-devel] [POC proxmox-backup 4/4] client: http: Use custom resolver for statically linked binary Christian Ebner
2024-10-08 14:50 ` Gabriel Goller [this message]
2024-10-08 15:13 ` [pbs-devel] [POC proxmox proxmox-backup 0/4] use custom DNS resolver for Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008145026.cclpx3xgdraau53i@luna.proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox