Re: [pbs-devel] applied: [PATCH v2] add tracing init_cli_logger and deprecate old one

From: Gabriel Goller <g.goller@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] applied: [PATCH v2] add tracing init_cli_logger and deprecate old one
Date: Tue, 3 Sep 2024 16:40:31 +0200	[thread overview]
Message-ID: <20240903144031.of26qkrnn5rwt3n3@luna.proxmox.com> (raw)
In-Reply-To: <kxkn3sg5v6kgaq3oikh673bazqja5kmd3wz3sg4czjv6xp656u@zzotijq45inm>

On 03.09.2024 14:38, Wolfgang Bumiller wrote:
>On Tue, Sep 03, 2024 at 02:27:24PM GMT, Gabriel Goller wrote:
>> On 03.09.2024 14:21, Wolfgang Bumiller wrote:
>> > On Tue, Sep 03, 2024 at 02:10:51PM GMT, Gabriel Goller wrote:
>> > > Christian Ebner and I just noticed that previously all the output was on
>> > > stderr, because the `env_logger` prints everything to stderr
>> > > per-default [0]. This means that all the console output from
>> > > proxmox-backup-client, -manager, -debug, -file-restore, pxar, etc. is
>> > > now on stdout.
>> > >
>> > > There is one test failing in pxar-bin, but I have a patch ready for that
>> > > already.
>> > >
>> > > But will this cause more problems down the road? Do we rely somwhere on the
>> > > stderr output? Should I change the tracing output to stderr as well?
>> > >
>> > > [0]: https://docs.rs/env_logger/latest/env_logger/
>> >
>> > Yeah having logs go to stderr would make sense.
>> > CLI tool output that is meant to be "useful" for *tooling* should be
>> > printed with `println!()` after all, not "logged".
>>
>> Ok, will send a patch soon!
>> Currently we nearly always log in our cli-tools, but maybe we should
>> start using println?
>
>I don't think we mostly log. Most of the time we call some API call
>and then use `format_and_print_result()` & friends.

Well, the proxmox-backup-client mostly logs...
e.g. `create_backup` (proxmox-backup-client/src/main.rs:741), `restore`
(proxmox-backup-client/src/main.rs:1475) and many more.

>The point is not to *always* use `println!()` for everything, but for
>what is to be considered the actual "output" of the command.

Yes, I agree.

>If there are cases where this is wrong, then yes, this should be
>corrected.
>
>I do wonder, though, whether CLI tools should move the default log level
>to "error". Most of the "info" level stuff shouldn't matter IMO.

We could do that and transform all `info` logs to `println`'s (this
probably makes sense nearly everywhere).

_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel