public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pbs-devel@lists.proxmox.com
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: [pbs-devel] [PATCH proxmox v2] systemd: debcargo: add libsystemd-dev to dependencies
Date: Fri, 23 Aug 2024 15:01:30 +0200	[thread overview]
Message-ID: <20240823130130.339924-1-m.sandoval@proxmox.com> (raw)

`Build-Depends` and `Depends` in d/control are missing `libsystemd-dev`,
resulting in mk-build-deps not being able to install all dependencies
needed by `make deb`.

After running `make deb` the control file looks:

```diff
modified   proxmox-systemd/debian/control
@@ -6,7 +6,8 @@ Build-Depends: debhelper (>= 12),
  cargo:native <!nocheck>,
  rustc:native <!nocheck>,
  libstd-rust-dev <!nocheck>,
- librust-libc-0.2+default-dev (>= 0.2.107-~~) <!nocheck>
+ librust-libc-0.2+default-dev (>= 0.2.107-~~) <!nocheck>,
+ libsystemd-dev <!nocheck>
 Maintainer: Proxmox Support Team <support@proxmox.com>
 Standards-Version: 4.6.2
 Vcs-Git: git://git.proxmox.com/git/proxmox.git
@@ -19,7 +20,8 @@ Architecture: any
 Multi-Arch: same
 Depends:
  ${misc:Depends},
- librust-libc-0.2+default-dev (>= 0.2.107-~~)
+ librust-libc-0.2+default-dev (>= 0.2.107-~~),
+ libsystemd-dev
 Provides:
  librust-proxmox-systemd+default-dev (= ${binary:Version}),
  librust-proxmox-systemd-0-dev (= ${binary:Version}),
```

Suggested-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---

Diferences from v1:
 - Remove d/control bits

 proxmox-systemd/debian/debcargo.toml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/proxmox-systemd/debian/debcargo.toml b/proxmox-systemd/debian/debcargo.toml
index b7864cdb..e2bbc37b 100644
--- a/proxmox-systemd/debian/debcargo.toml
+++ b/proxmox-systemd/debian/debcargo.toml
@@ -5,3 +5,6 @@ maintainer = "Proxmox Support Team <support@proxmox.com>"
 [source]
 vcs_git = "git://git.proxmox.com/git/proxmox.git"
 vcs_browser = "https://git.proxmox.com/?p=proxmox.git"
+
+[packages.lib]
+depends = [ "libsystemd-dev" ]
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


             reply	other threads:[~2024-08-23 13:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-23 13:01 Maximiliano Sandoval [this message]
2024-08-28 12:19 ` [pbs-devel] applied: " Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240823130130.339924-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal