From: Christoph Heiss <c.heiss@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup/pwt v4 00/16] fix #5379: introduce default auth realm option
Date: Fri, 23 Aug 2024 13:07:20 +0200 [thread overview]
Message-ID: <20240823110737.831304-1-c.heiss@proxmox.com> (raw)
Fixes #5379 [0].
First, it adds an updatable `default` field to all existing editable
realms. Then it converts the PAM and PBS built-in realms to proper
realms, instead of being hard-coded in-between somewhere.
In turns this enables editing of these realms, allowing setting whether
these realms should be the default for login or not.
For proxmox-widget-toolkit, the first three patches could in principal
be applied on their own. The others depend on the API changes as
introduced in the proxmox-backup part.
W.r.t. the inconsistency as discovered/discussed in [1], the (current)
behaviour is not changed in this series. Since both PVE and PBS use the
same realm login dialog from proxmox-widget-toolkit, I'd rather fix it
separately -- to avoid blocking this series on a completely separate
issue, which might still need some discussing.
W.r.t. to applying, proxmox-backup will need a bump of
proxmox-widget-toolkit afterwards.
[0] https://bugzilla.proxmox.com/show_bug.cgi?id=5379
[1] https://lists.proxmox.com/pipermail/pbs-devel/2024-August/010429.html
History
=======
v3: https://lists.proxmox.com/pipermail/pbs-devel/2024-August/010605.html
v2: https://lists.proxmox.com/pipermail/pbs-devel/2024-August/010521.html
v1: https://lists.proxmox.com/pipermail/pbs-devel/2024-July/010250.html
Changes v3 -> v4:
* added proper PAM/PBS realm documentation
* reworked SimpleRealmInputPanel properties (thanks Gabriel & Hannes!)
Changes v2 -> v3:
* rebased on latest master
* fixed unsetting the `default` property by making it deletable
* unset previous default realm when creating a new realm with
`default` set
Changes v1 -> v2:
* rebased on latest master
* trivial fixes as suggested by Lukas
* add documentation to unset_default_realm()
Diffstat
========
proxmox-widget-toolkit:
Christoph Heiss (7):
window: AuthEditBase: include more information in thrown errors
panel: AuthView: make `useTypeInUrl` property per-realm
panel: AuthView: use help link from schema if set
window: add panel for editing simple, built-in realms
schema: make PAM realm editable using new AuthSimple panel
fix #5379: panel: AuthView: add column displaying whether the realm is
default
fix #5379: window: AuthEdit{LDAP,OpenId}: add 'Default realm' checkbox
src/Makefile | 1 +
src/Schema.js | 8 +++++++-
src/panel/AuthView.js | 16 ++++++++++++---
src/window/AuthEditBase.js | 8 ++++----
src/window/AuthEditLDAP.js | 14 ++++++++++++-
src/window/AuthEditOpenId.js | 13 ++++++++++++
src/window/AuthEditSimple.js | 40 ++++++++++++++++++++++++++++++++++++
7 files changed, 91 insertions(+), 9 deletions(-)
create mode 100644 src/window/AuthEditSimple.js
proxmox-backup:
Christoph Heiss (9):
fix #5379: api-types: add `default` field to all realm types
fix #5379: api2: access: set default realm accordingly on individual
update
api-types: introduce proper types for PAM and PBS realms
config: use new dedicated PAM and PBS realm types
api2: access: add update support for built-in PAM realm
api2: access: add update support for built-in PBS realm
www: AccessControl: make `useTypeInUrl` property per-realm
www: utils: make built-in pbs realm editable using new AuthSimplePanel
docs: user-management: document `pam` and `pbs` authentication realm
docs/user-management.rst | 30 ++++++-
pbs-api-types/src/ad.rs | 7 ++
pbs-api-types/src/ldap.rs | 7 ++
pbs-api-types/src/lib.rs | 97 ++++++++++++++++++++++-
pbs-api-types/src/openid.rs | 7 ++
pbs-config/src/domains.rs | 36 ++++++++-
src/api2/access/domain.rs | 13 ----
src/api2/config/access/ad.rs | 16 ++++
src/api2/config/access/ldap.rs | 16 ++++
src/api2/config/access/mod.rs | 4 +
src/api2/config/access/openid.rs | 16 ++++
src/api2/config/access/pam.rs | 130 +++++++++++++++++++++++++++++++
src/api2/config/access/pbs.rs | 130 +++++++++++++++++++++++++++++++
src/bin/proxmox-backup-api.rs | 1 +
src/config/mod.rs | 25 ++++++
www/OnlineHelpInfo.js | 8 ++
www/Utils.js | 5 +-
www/panel/AccessControl.js | 1 -
18 files changed, 529 insertions(+), 20 deletions(-)
create mode 100644 src/api2/config/access/pam.rs
create mode 100644 src/api2/config/access/pbs.rs
--
2.45.1
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2024-08-23 11:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 11:07 Christoph Heiss [this message]
2024-08-23 11:07 ` [pbs-devel] [PATCH widget-toolkit v4 1/7] window: AuthEditBase: include more information in thrown errors Christoph Heiss
2024-08-23 11:07 ` [pbs-devel] [PATCH widget-toolkit v4 2/7] panel: AuthView: make `useTypeInUrl` property per-realm Christoph Heiss
2024-08-23 11:07 ` [pbs-devel] [PATCH widget-toolkit v4 3/7] panel: AuthView: use help link from schema if set Christoph Heiss
2024-08-23 11:07 ` [pbs-devel] [PATCH widget-toolkit v4 4/7] window: add panel for editing simple, built-in realms Christoph Heiss
2024-08-23 11:07 ` [pbs-devel] [PATCH widget-toolkit v4 5/7] schema: make PAM realm editable using new AuthSimple panel Christoph Heiss
2024-08-23 11:07 ` [pbs-devel] [PATCH widget-toolkit v4 6/7] fix #5379: panel: AuthView: add column displaying whether the realm is default Christoph Heiss
2024-08-23 11:07 ` [pbs-devel] [PATCH widget-toolkit v4 7/7] fix #5379: window: AuthEdit{LDAP, OpenId}: add 'Default realm' checkbox Christoph Heiss
2024-08-23 11:07 ` [pbs-devel] [PATCH proxmox-backup v4 08/16] fix #5379: api-types: add `default` field to all realm types Christoph Heiss
2024-08-23 11:07 ` [pbs-devel] [PATCH proxmox-backup v4 09/16] fix #5379: api2: access: set default realm accordingly on individual update Christoph Heiss
2024-08-23 11:07 ` [pbs-devel] [PATCH proxmox-backup v4 10/16] api-types: introduce proper types for PAM and PBS realms Christoph Heiss
2024-08-23 11:07 ` [pbs-devel] [PATCH proxmox-backup v4 11/16] config: use new dedicated PAM and PBS realm types Christoph Heiss
2024-08-23 11:07 ` [pbs-devel] [PATCH proxmox-backup v4 12/16] api2: access: add update support for built-in PAM realm Christoph Heiss
2024-08-23 11:07 ` [pbs-devel] [PATCH proxmox-backup v4 13/16] api2: access: add update support for built-in PBS realm Christoph Heiss
2024-08-23 11:07 ` [pbs-devel] [PATCH proxmox-backup v4 14/16] www: AccessControl: make `useTypeInUrl` property per-realm Christoph Heiss
2024-08-23 11:07 ` [pbs-devel] [PATCH proxmox-backup v4 15/16] www: utils: make built-in pbs realm editable using new AuthSimplePanel Christoph Heiss
2024-08-23 11:07 ` [pbs-devel] [PATCH proxmox-backup v4 16/16] docs: user-management: document `pam` and `pbs` authentication realm Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240823110737.831304-1-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox