[pbs-devel] [PATCH proxmox 01/15] daemon: Remove unused once_cell dependency

[pbs-devel] [PATCH proxmox 01/15] daemon: Remove unused once_cell dependency

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
This series removes multiple unused dependencies. It depends on the previous series removing lazy-static.

These were detected using:

    cargo machete --fix

Some macros have imports under the hood so Machete can produce false-positives for regex and serde for example.

This was tested building proxmox with

    cargo build --workspace --all-targets --all-features

and when building the project as a dependency of the following projects:
 - pbs
 - pve-rs
 - pmg-rs
 - pom

 proxmox-daemon/Cargo.toml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/proxmox-daemon/Cargo.toml b/proxmox-daemon/Cargo.toml
index 13bb3bc8..6bc30421 100644
--- a/proxmox-daemon/Cargo.toml
+++ b/proxmox-daemon/Cargo.toml
@@ -17,7 +17,6 @@ futures.workspace = true
 libc.workspace = true
 log.workspace = true
 nix.workspace = true
-once_cell.workspace = true
 serde.workspace = true
 serde_json.workspace = true
 tokio = { workspace = true, features = ["io-util", "net", "rt", "signal", "sync"] }
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 02/15] proxmox-uuid: remove unused libc dependency

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-uuid/Cargo.toml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/proxmox-uuid/Cargo.toml b/proxmox-uuid/Cargo.toml
index 55154187..7ca5ff07 100644
--- a/proxmox-uuid/Cargo.toml
+++ b/proxmox-uuid/Cargo.toml
@@ -10,7 +10,6 @@ description = "bindings for libuuid with optional serde support"
 exclude.workspace = true
 
 [dependencies]
-libc.workspace = true
 serde = { workspace = true, optional = true }
 
 [features]
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 03/15] sys: remove unused base64 dependency

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-sys/Cargo.toml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/proxmox-sys/Cargo.toml b/proxmox-sys/Cargo.toml
index c5d2bd87..6f8431ad 100644
--- a/proxmox-sys/Cargo.toml
+++ b/proxmox-sys/Cargo.toml
@@ -12,7 +12,6 @@ exclude.workspace = true
 
 [dependencies]
 anyhow.workspace = true
-base64.workspace = true
 libc.workspace = true
 log.workspace = true
 nix.workspace = true
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 04/15] simple-config: remove unused log dependency

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-simple-config/Cargo.toml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/proxmox-simple-config/Cargo.toml b/proxmox-simple-config/Cargo.toml
index d957edd0..4c4d35d7 100644
--- a/proxmox-simple-config/Cargo.toml
+++ b/proxmox-simple-config/Cargo.toml
@@ -12,6 +12,5 @@ description = "Simple key/value format for configuration files."
 anyhow.workspace = true
 serde_json.workspace = true
 serde = { workspace = true, features = ["derive"] }
-log = { workspace = true, optional = true }
 
 proxmox-schema = { workspace = true, features = ["api-macro", "api-types"] }
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 05/15] rrd: remove unused libc dependency

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-rrd/Cargo.toml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/proxmox-rrd/Cargo.toml b/proxmox-rrd/Cargo.toml
index 5678fd4d..72aad8f9 100644
--- a/proxmox-rrd/Cargo.toml
+++ b/proxmox-rrd/Cargo.toml
@@ -15,7 +15,6 @@ proxmox-router = { workspace = true, features = ["cli", "server"] }
 anyhow.workspace = true
 bitflags.workspace = true
 crossbeam-channel.workspace = true
-libc.workspace = true
 log.workspace = true
 nix.workspace = true
 serde.workspace = true
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 06/15] acme-api: remove unused dependencies

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-acme-api/Cargo.toml | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/proxmox-acme-api/Cargo.toml b/proxmox-acme-api/Cargo.toml
index d00d8ab7..ca37d3db 100644
--- a/proxmox-acme-api/Cargo.toml
+++ b/proxmox-acme-api/Cargo.toml
@@ -16,8 +16,6 @@ futures = { workspace = true, optional = true }
 hex = { workspace = true, optional = true }
 http = { workspace = true, optional = true }
 hyper = { workspace = true, optional = true }
-log = { workspace = true, optional = true }
-nix = { workspace = true, optional = true }
 serde = { workspace = true, features = ["derive"] }
 serde_json = { workspace = true }
 tokio = { workspace = true, optional = true, features = ["fs"] }
@@ -49,8 +47,6 @@ impl = [
     "dep:http",
     "dep:hyper",
     "dep:libc",
-    "dep:log",
-    "dep:nix",
     "dep:openssl",
     "dep:tokio",
 
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 07/15] apt: remove unused dependencies

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-apt/Cargo.toml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/proxmox-apt/Cargo.toml b/proxmox-apt/Cargo.toml
index c35c11ba..0e9fbbdc 100644
--- a/proxmox-apt/Cargo.toml
+++ b/proxmox-apt/Cargo.toml
@@ -13,7 +13,6 @@ exclude = ["debian"]
 [dependencies]
 anyhow.workspace = true
 hex.workspace = true
-once_cell.workspace = true
 openssl.workspace = true
 serde = { workspace = true, features = ["derive"] }
 serde_json.workspace = true
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 08/15] proxmox-client: remove unused dependencies

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-client/Cargo.toml | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/proxmox-client/Cargo.toml b/proxmox-client/Cargo.toml
index f9898083..d7f78cf7 100644
--- a/proxmox-client/Cargo.toml
+++ b/proxmox-client/Cargo.toml
@@ -10,30 +10,21 @@ repository.workspace = true
 
 [dependencies]
 anyhow.workspace = true
-base64.workspace = true
 hex.workspace = true
 http.workspace = true
-once_cell.workspace = true
-percent-encoding.workspace = true
-regex.workspace = true
 serde.workspace = true
 serde_json.workspace = true
-serde_plain.workspace = true
 
 # wasm-incompatible dependencies must stay optional
 log = { workspace = true, optional = true }
 openssl = { workspace = true, optional = true }
 
 proxmox-login = { workspace = true, features = [ "http" ] }
-webauthn-rs = { workspace = true, optional = true }
 
 proxmox-http = { workspace = true, optional = true, features = [ "client" ] }
 hyper = { workspace = true, optional = true }
 
-proxmox-section-config.workspace = true
-proxmox-schema = { workspace = true, features = [ "api-macro" ] }
-
 [features]
 default = []
 hyper-client = [ "dep:openssl", "dep:hyper", "dep:proxmox-http", "dep:log" ]
-webauthn = [ "dep:webauthn-rs", "proxmox-login/webauthn" ]
+webauthn = [ "proxmox-login/webauthn" ]
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 09/15] rest-server: remove unused dependencies

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-rest-server/Cargo.toml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/proxmox-rest-server/Cargo.toml b/proxmox-rest-server/Cargo.toml
index e35cb42f..280e035a 100644
--- a/proxmox-rest-server/Cargo.toml
+++ b/proxmox-rest-server/Cargo.toml
@@ -45,7 +45,6 @@ proxmox-log.workspace = true
 proxmox-router.workspace = true
 proxmox-schema = { workspace = true, features = [ "api-macro", "upid-api-impl" ] }
 proxmox-sys = { workspace = true, features = [ "logrotate", "timer" ] }
-proxmox-systemd.workspace = true
 proxmox-time.workspace = true
 proxmox-worker-task.workspace = true
 
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 10/15] log: remove unused log dependency

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-log/Cargo.toml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/proxmox-log/Cargo.toml b/proxmox-log/Cargo.toml
index 98432d8c..5e6dd0c4 100644
--- a/proxmox-log/Cargo.toml
+++ b/proxmox-log/Cargo.toml
@@ -12,7 +12,6 @@ exclude.workspace = true
 [dependencies]
 anyhow.workspace = true
 nix.workspace = true
-log.workspace = true
 tracing.workspace = true
 tracing-journald.workspace = true
 tracing-subscriber.workspace = true
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 11/15] dns-api: remove unused dependencies

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-dns-api/Cargo.toml | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/proxmox-dns-api/Cargo.toml b/proxmox-dns-api/Cargo.toml
index 98045b34..1546d697 100644
--- a/proxmox-dns-api/Cargo.toml
+++ b/proxmox-dns-api/Cargo.toml
@@ -19,14 +19,10 @@ proxmox-config-digest.workspace = true
 proxmox-schema = { workspace = true, features = ["api-macro", "api-types"] }
 
 proxmox-sys = { workspace = true, optional = true }
-proxmox-time = { workspace = true, optional = true }
-proxmox-product-config = { workspace = true, optional = true }
 
 [features]
 default = []
 impl = [
-    "dep:proxmox-product-config",
     "proxmox-config-digest/openssl",
     "dep:proxmox-sys",
-    "dep:proxmox-time",
 ]
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 12/15] product-config: remove unused dependencies

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-product-config/Cargo.toml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/proxmox-product-config/Cargo.toml b/proxmox-product-config/Cargo.toml
index 525e2650..5bee7e21 100644
--- a/proxmox-product-config/Cargo.toml
+++ b/proxmox-product-config/Cargo.toml
@@ -11,7 +11,5 @@ exclude.workspace = true
 
 [dependencies]
 anyhow.workspace = true
-hex.workspace = true
-log.workspace = true
 nix.workspace = true
 proxmox-sys = { workspace = true, features = ["timer"] }
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 13/15] openid: remove unused dependencies

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-openid/Cargo.toml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/proxmox-openid/Cargo.toml b/proxmox-openid/Cargo.toml
index 243b04b7..f5d86f36 100644
--- a/proxmox-openid/Cargo.toml
+++ b/proxmox-openid/Cargo.toml
@@ -18,7 +18,6 @@ serde = { workspace = true, features = ["derive"] }
 serde_json.workspace = true
 thiserror = "1"
 native-tls.workspace = true
-url.workspace = true
 
 openidconnect = { version = "2.4", default-features = false, features = ["accept-rfc3339-timestamps"] }
 ureq = { version = "2.4", default-features = false, features = ["native-tls", "gzip"] }
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 14/15] router: remove unused deps

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-router/Cargo.toml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/proxmox-router/Cargo.toml b/proxmox-router/Cargo.toml
index 2dc48b5d..33e864ef 100644
--- a/proxmox-router/Cargo.toml
+++ b/proxmox-router/Cargo.toml
@@ -26,10 +26,8 @@ serde = { workspace = true, features = [ "derive" ] }
 serde_json.workspace = true
 serde_plain.workspace = true
 unicode-width ="0.1.8"
-regex = { workspace = true, optional = true }
 
 # cli:
-tokio = { workspace = true, features = [], optional = true }
 rustyline = { version = "9", optional = true }
 libc = { workspace = true, optional = true }
 
@@ -39,6 +37,6 @@ proxmox-async.workspace = true
 
 [features]
 default = [ "cli", "server" ]
-cli = [ "dep:env_logger", "dep:libc", "dep:rustyline", "dep:tokio", "dep:regex" ]
+cli = [ "dep:env_logger", "dep:libc", "dep:rustyline" ]
 server = [ "dep:http", "dep:hyper" ]
 test-harness = [ "proxmox-schema/test-harness" ]
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 15/15] rest-server: remove use of once_cell

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 Cargo.toml                             | 1 -
 proxmox-rest-server/Cargo.toml         | 1 -
 proxmox-rest-server/src/worker_task.rs | 3 +--
 3 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml
index 6360db1f..2b012974 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -90,7 +90,6 @@ log = "0.4.17"
 mail-parser = "0.8.2"
 native-tls = "0.2"
 nix = "0.26.1"
-once_cell = "1.3.1"
 openssl = "0.10"
 pam-sys = "0.5"
 percent-encoding = "2.1"
diff --git a/proxmox-rest-server/Cargo.toml b/proxmox-rest-server/Cargo.toml
index 280e035a..45751d7e 100644
--- a/proxmox-rest-server/Cargo.toml
+++ b/proxmox-rest-server/Cargo.toml
@@ -23,7 +23,6 @@ hyper = { workspace = true, features = [ "full" ] }
 libc.workspace = true
 log.workspace = true
 nix.workspace = true
-once_cell.workspace = true
 openssl.workspace = true
 percent-encoding.workspace = true
 regex.workspace = true
diff --git a/proxmox-rest-server/src/worker_task.rs b/proxmox-rest-server/src/worker_task.rs
index 228abb7f..6e76c2ca 100644
--- a/proxmox-rest-server/src/worker_task.rs
+++ b/proxmox-rest-server/src/worker_task.rs
@@ -10,7 +10,6 @@ use std::time::{Duration, SystemTime};
 use anyhow::{bail, format_err, Error};
 use futures::*;
 use nix::fcntl::OFlag;
-use once_cell::sync::OnceCell;
 use serde::{Deserialize, Serialize};
 use serde_json::{json, Value};
 use tokio::signal::unix::SignalKind;
@@ -99,7 +98,7 @@ struct WorkerTaskSetup {
     task_archive_fn: PathBuf,
 }
 
-static WORKER_TASK_SETUP: OnceCell<WorkerTaskSetup> = OnceCell::new();
+static WORKER_TASK_SETUP: OnceLock<WorkerTaskSetup> = OnceLock::new();
 
 fn worker_task_setup() -> Result<&'static WorkerTaskSetup, Error> {
     WORKER_TASK_SETUP
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied-series: [PATCH proxmox 01/15] daemon: Remove unused once_cell dependency

[Wolfgang Bumiller]

applied series, thanks


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel