From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 2/2] web: disallow datastore in root, add reuse-datastore flag
Date: Wed, 14 Aug 2024 10:56:47 +0200 [thread overview]
Message-ID: <20240814085647.bmotzzigcrsnwshu@luna.proxmox.com> (raw)
In-Reply-To: <26a0cacf-8f44-42fa-868f-8125fde361a4@proxmox.com>
On 22.07.2024 08:52, Thomas Lamprecht wrote:
>Am 18/07/2024 um 14:29 schrieb Gabriel Goller:
>> Disallows creating a datastore in root on the frontend side, by
>> filtering the '/' path. Add reuse-flag to permit us to open existing
>> datastores.
>>
>> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
>> ---
>> www/window/DataStoreEdit.js | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/www/window/DataStoreEdit.js b/www/window/DataStoreEdit.js
>> index b61154606284..2565688e26ce 100644
>> --- a/www/window/DataStoreEdit.js
>> +++ b/www/window/DataStoreEdit.js
>> @@ -61,6 +61,17 @@ Ext.define('PBS.DataStoreEdit', {
>> allowBlank: false,
>> fieldLabel: gettext('Backing Path'),
>> emptyText: gettext('An absolute path'),
>> + validator: function(val) {
>> + if (val.trim() === '/') {
>> + return false;
>> + }
>> + return true;
>> + },
>> + },
>> + {
>> + xtype: 'checkbox',
>> + name: 'reuse-datastore',
>> + fieldLabel: gettext('Reuse existing datastore'),
>> },
>> ],
>> column2: [
>
>I missed that there is a new version already, but as this patch is
>unchanged the review from v2 of this patch [0] still applies.
>
>[0]: https://lists.proxmox.com/pipermail/pbs-devel/2024-July/010303.html
Oops, missed this one, v4 is on the list!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-08-14 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 12:29 [pbs-devel] [PATCH proxmox-backup v3 1/2] fix #5439: allow to reuse existing datastore Gabriel Goller
2024-07-18 12:29 ` [pbs-devel] [PATCH proxmox-backup v3 2/2] web: disallow datastore in root, add reuse-datastore flag Gabriel Goller
2024-07-22 6:52 ` Thomas Lamprecht
2024-08-14 8:56 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814085647.bmotzzigcrsnwshu@luna.proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox