From: Gabriel Goller <g.goller@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] datastore: remove unsafe from function
Date: Wed, 3 Jul 2024 16:58:53 +0200 [thread overview]
Message-ID: <20240703145857.456017-1-g.goller@proxmox.com> (raw)
`list_snapshots_blocking` doesn't need to be unsafe.
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
src/api2/admin/datastore.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs
index 82221c503d16..f28fb97fa975 100644
--- a/src/api2/admin/datastore.rs
+++ b/src/api2/admin/datastore.rs
@@ -451,7 +451,7 @@ pub async fn list_snapshots(
) -> Result<Vec<SnapshotListItem>, Error> {
let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?;
- tokio::task::spawn_blocking(move || unsafe {
+ tokio::task::spawn_blocking(move || {
list_snapshots_blocking(store, ns, backup_type, backup_id, auth_id)
})
.await
@@ -459,7 +459,7 @@ pub async fn list_snapshots(
}
/// This must not run in a main worker thread as it potentially does tons of I/O.
-unsafe fn list_snapshots_blocking(
+fn list_snapshots_blocking(
store: String,
ns: Option<BackupNamespace>,
backup_type: Option<BackupType>,
--
2.43.0
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2024-07-03 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 14:58 Gabriel Goller [this message]
2024-07-04 9:59 ` Christian Ebner
2024-07-04 11:05 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703145857.456017-1-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox