From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH promox v4 2/5] compression: deflate: add builder pattern
Date: Wed, 26 Jun 2024 16:57:58 +0200 [thread overview]
Message-ID: <20240626145801.751326-3-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20240626145801.751326-1-m.sandoval@proxmox.com>
This allows creating a encoder in a more general way and allows to
specify whether we want to set zlib headers. This is useful to compress
HTTP traffic, as per [1].
[1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding#directives
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
.../src/deflate/compression.rs | 55 ++++++++++++++++---
1 file changed, 46 insertions(+), 9 deletions(-)
diff --git a/proxmox-compression/src/deflate/compression.rs b/proxmox-compression/src/deflate/compression.rs
index 6e6a151d..24d2bc99 100644
--- a/proxmox-compression/src/deflate/compression.rs
+++ b/proxmox-compression/src/deflate/compression.rs
@@ -35,27 +35,64 @@ pub struct DeflateEncoder<T> {
state: EncoderState,
}
-impl<T> DeflateEncoder<T> {
- pub fn new(inner: T) -> Self {
- Self::with_quality(inner, Level::Default)
+pub struct DeflateEncoderBuilder<T> {
+ inner: T,
+ is_zlib: bool,
+ buffer_size: usize,
+ level: Level,
+}
+
+impl<T> DeflateEncoderBuilder<T> {
+ pub fn zlib(mut self, is_zlib: bool) -> Self {
+ self.is_zlib = is_zlib;
+ self
}
- pub fn with_quality(inner: T, level: Level) -> Self {
- let level = match level {
+ pub fn level(mut self, level: Level) -> Self {
+ self.level = level;
+ self
+ }
+
+ pub fn buffer_size(mut self, buffer_size: usize) -> Self {
+ self.buffer_size = buffer_size;
+ self
+ }
+
+ pub fn build(self) -> DeflateEncoder<T> {
+ let level = match self.level {
Level::Fastest => Compression::fast(),
Level::Best => Compression::best(),
Level::Default => Compression::new(3),
Level::Precise(val) => Compression::new(val),
};
- Self {
- inner,
- compressor: Compress::new(level, false),
- buffer: ByteBuffer::with_capacity(super::BUFFER_SIZE),
+ DeflateEncoder {
+ inner: self.inner,
+ compressor: Compress::new(level, self.is_zlib),
+ buffer: ByteBuffer::with_capacity(self.buffer_size),
input_buffer: Bytes::new(),
state: EncoderState::Reading,
}
}
+}
+
+impl<T> DeflateEncoder<T> {
+ pub fn new(inner: T) -> Self {
+ Self::builder(inner).build()
+ }
+
+ pub fn builder(inner: T) -> DeflateEncoderBuilder<T> {
+ DeflateEncoderBuilder {
+ inner,
+ is_zlib: false,
+ buffer_size: super::BUFFER_SIZE,
+ level: Level::Default,
+ }
+ }
+
+ pub fn with_quality(inner: T, level: Level) -> Self {
+ Self::builder(inner).level(level).build()
+ }
pub fn total_in(&self) -> u64 {
self.compressor.total_in()
--
2.39.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-06-26 14:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 14:57 [pbs-devel] [PATCH promox v4 0/5] Teach HTTP client how to decode deflate Maximiliano Sandoval
2024-06-26 14:57 ` [pbs-devel] [PATCH promox v4 1/5] compression: deflate: move encoder into a mod Maximiliano Sandoval
2024-07-03 13:57 ` Max Carrara
2024-07-05 13:01 ` Maximiliano Sandoval
2024-06-26 14:57 ` Maximiliano Sandoval [this message]
2024-06-26 14:57 ` [pbs-devel] [PATCH promox v4 3/5] compression: deflate: add a decoder Maximiliano Sandoval
2024-06-26 14:58 ` [pbs-devel] [PATCH promox v4 4/5] compression: deflate: add test module Maximiliano Sandoval
2024-06-26 14:58 ` [pbs-devel] [PATCH promox v4 5/5] http: teach the Client how to decode deflate content Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626145801.751326-3-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox