From: Gabriel Goller <g.goller@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup] client: mount: flush output before exiting
Date: Fri, 14 Jun 2024 11:40:08 +0200 [thread overview]
Message-ID: <20240614094008.mvycpo7vfratpyes@luna.proxmox.com> (raw)
In-Reply-To: <148421272.16.1718357809538@webmail.proxmox.com>
On 14.06.2024 11:36, Christian Ebner wrote:
>> diff --git a/proxmox-backup-client/src/mount.rs b/proxmox-backup-client/src/mount.rs
>> index b69e7e80..001cbd62 100644
>> --- a/proxmox-backup-client/src/mount.rs
>> +++ b/proxmox-backup-client/src/mount.rs
>> @@ -1,6 +1,7 @@
>> use std::collections::HashMap;
>> use std::ffi::OsStr;
>> use std::hash::BuildHasher;
>> +use std::io::{self, Write};
>> use std::os::unix::io::{AsRawFd, OwnedFd};
>> use std::path::{Path, PathBuf};
>> use std::sync::Arc;
>> @@ -189,7 +190,11 @@ fn mount(
>> Ok(ForkResult::Child) => {
>> drop(pr);
>> nix::unistd::setsid().unwrap();
>> - proxmox_async::runtime::main(mount_do(param, Some(pw)))
>> + let result =
>> + proxmox_async::runtime::main(mount_do(param, Some(pw.try_clone().unwrap())));
>
>Why do you clone here?
Oops, my bad. Forgot to remove this.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-06-14 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 9:23 Gabriel Goller
2024-06-14 9:36 ` Christian Ebner
2024-06-14 9:40 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614094008.mvycpo7vfratpyes@luna.proxmox.com \
--to=g.goller@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox