From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/3] tape: disable Programmable Early Warning Zone (PEWZ)
Date: Mon, 10 Jun 2024 13:45:04 +0200 [thread overview]
Message-ID: <20240610114505.2211336-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20240610114505.2211336-1-d.csapak@proxmox.com>
since that leads to errors that we don't currently catch before we
reach the regular early warning on tape.
This can be read/set by the Device Configuration Extension Mode Page.
ignore errors on reading or writing, since it may not be available on
LTO-4
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
pbs-tape/src/sg_tape.rs | 71 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 71 insertions(+)
diff --git a/pbs-tape/src/sg_tape.rs b/pbs-tape/src/sg_tape.rs
index 1aa7d492..96cd3ed8 100644
--- a/pbs-tape/src/sg_tape.rs
+++ b/pbs-tape/src/sg_tape.rs
@@ -82,6 +82,32 @@ impl DataCompressionModePage {
}
}
+#[repr(C, packed)]
+#[derive(Endian, Debug, Copy, Clone)]
+struct DeviceConfigurationExtensionModePage {
+ page_code: u8, // 0x10
+ sub_page_code: u8, // 0x01
+ page_length: u16, // 0x1C
+ flags4: u8,
+ modes: u8,
+ pews: u16,
+ flags8: u8,
+ reserved: [u8; 23],
+}
+
+impl DeviceConfigurationExtensionModePage {
+ /// Sets the Programmable Early Warning Zone to the given amount, rounded up to the next
+ /// Megabyte (10^6 bytes) up to 2^16 Megabyte (the value will be clamped)
+ pub fn set_pewz(&mut self, bytes: usize) {
+ let mbytes = if bytes == 0 {
+ 0
+ } else {
+ (bytes / 1000 / 1000) + 1
+ };
+ self.pews = mbytes.clamp(0, u16::MAX as usize) as u16;
+ }
+}
+
#[repr(C, packed)]
#[derive(Endian)]
struct MediumConfigurationModePage {
@@ -891,6 +917,16 @@ impl SgTape {
self.drive_mode_select(head, block_descriptor, page)?;
+ // LTO-4 does not support this page, but try to write it if we can read it
+ if let Ok((mut head, block_descriptor, mut page)) =
+ self.read_device_configuration_extension_page()
+ {
+ head.reset_mode_data_len(); // mode_data_len need to be zero
+ page.set_pewz(0); // disable PEWZ
+
+ let _ = self.drive_mode_select(head, block_descriptor, page);
+ }
+
Ok(())
}
@@ -956,6 +992,41 @@ impl SgTape {
.map_err(|err| format_err!("read_compression_page failed: {err}"))
}
+ fn read_device_configuration_extension_page(
+ &mut self,
+ ) -> Result<
+ (
+ ModeParameterHeader,
+ ModeBlockDescriptor,
+ DeviceConfigurationExtensionModePage,
+ ),
+ Error,
+ > {
+ let (head, block_descriptor, page): (_, _, DeviceConfigurationExtensionModePage) =
+ scsi_mode_sense(&mut self.file, false, 0x10, 0x01)?;
+
+ proxmox_lang::try_block!({
+ if (page.page_code & 0b0011_1111) != 0x10 {
+ bail!("wrong page code {}", page.page_code);
+ }
+ if page.sub_page_code != 0x01 {
+ bail!("wrong sub page code {}", page.sub_page_code);
+ }
+ let page_length = page.page_length;
+ if page_length != 0x1C {
+ bail!("wrong page length {page_length}");
+ }
+
+ let block_descriptor = match block_descriptor {
+ Some(block_descriptor) => block_descriptor,
+ None => bail!("missing block descriptor"),
+ };
+
+ Ok((head, block_descriptor, page))
+ })
+ .map_err(|err| format_err!("read_device_configuration_extension_page failed: {err}"))
+ }
+
/// Read drive options/status
///
/// We read the drive compression page, including the
--
2.39.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-06-10 11:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 11:45 [pbs-devel] [PATCH proxmox-backup 1/3] tape: refactor setting the mode page Dominik Csapak
2024-06-10 11:45 ` Dominik Csapak [this message]
2024-06-10 11:45 ` [pbs-devel] [PATCH proxmox-backup 3/3] tape: handle PEWZ like regular early warning Dominik Csapak
2024-06-11 8:34 ` [pbs-devel] applied: [PATCH proxmox-backup 1/3] tape: refactor setting the mode page Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240610114505.2211336-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox