From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH widget-toolkit/proxmox-backup v2 0/5] fix #5463: add optional consent banner before login
Date: Fri, 7 Jun 2024 10:08:23 +0200 [thread overview]
Message-ID: <20240607080823.3zbgpjojsripgl7j@luna.proxmox.com> (raw)
In-Reply-To: <cc17fc9e-93a0-4628-9e96-f43135f9fd2d@proxmox.com>
On 06.06.2024 15:04, Thomas Lamprecht wrote:
>Am 06/06/2024 um 14:09 schrieb Dominik Csapak:
>>> I don't have any strong opinions though, so I'll let you decide... 🙂
>>> If we do it, we should maybe rename the option to consent_test_base64 or
>>> something, so that it's instantly visible that it's encoded?
>> yeah the name should probably reflect that, @thomas any opinion regarding
>> base64 ?
>
>We normally do not include the format in the property names, but it still
>_might_ be OK to add it there.
>Otherwise, the description can mention it and a validator should catch actual
>invalid base64 though, as any space is invalid it would be quite obvious to
>admins when the test how it looks.
>
>Alternatively (just as idea, not as recommendation) you could make it rather
>obvious by requiring a format, or encoding, like:
>
>ui_consent: format=base64,value=...
>
>or possibly already with the type in there:
>
>consent: type=ui,format=base64,value=...
Hmm, idk, for me this looks like there are different formats and types
available—which we don't plan to add anytime soon.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-06-07 8:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 12:50 Gabriel Goller
2024-06-04 12:50 ` [pbs-devel] [PATCH widget-toolkit v2 1/5] window: add consent modal Gabriel Goller
2024-06-04 12:50 ` [pbs-devel] [PATCH widget-toolkit v2 2/5] form: add support for multiline textarea Gabriel Goller
2024-06-04 12:50 ` [pbs-devel] [PATCH proxmox-backup v2 3/5] api: add consent api handler and config option Gabriel Goller
2024-06-04 12:50 ` [pbs-devel] [PATCH proxmox-backup v2 4/5] ui: show consent banner before login Gabriel Goller
2024-06-04 12:50 ` [pbs-devel] [PATCH proxmox-backup v2 5/5] docs: add section about consent banner Gabriel Goller
2024-06-05 13:22 ` [pbs-devel] [PATCH widget-toolkit/proxmox-backup v2 0/5] fix #5463: add optional consent banner before login Dominik Csapak
2024-06-06 10:18 ` Gabriel Goller
2024-06-06 10:30 ` Dominik Csapak
2024-06-06 11:25 ` Gabriel Goller
2024-06-06 12:09 ` Dominik Csapak
2024-06-06 12:56 ` Gabriel Goller
2024-06-06 13:04 ` Thomas Lamprecht
2024-06-07 8:08 ` Gabriel Goller [this message]
2024-06-07 11:48 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240607080823.3zbgpjojsripgl7j@luna.proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox