From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/2] client: pxar: conditionally skip metadata reference test
Date: Thu, 6 Jun 2024 10:17:11 +0200 [thread overview]
Message-ID: <20240606081711.91531-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20240606081711.91531-1-c.ebner@proxmox.com>
The test will fail for all users not having euid/egid set to
1000/1000, as the reference test folder structure cannot be created
with the expected ownership.
Therefore, skip over the test if either euid or egid do not match
this condition.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
pbs-client/src/pxar/create.rs | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs
index d5eb7bd02..56c82fe4d 100644
--- a/pbs-client/src/pxar/create.rs
+++ b/pbs-client/src/pxar/create.rs
@@ -1859,6 +1859,14 @@ mod tests {
#[test]
fn test_create_archive_with_reference() -> Result<(), Error> {
+ let euid = unsafe { libc::geteuid() };
+ let egid = unsafe { libc::getegid() };
+
+ if euid != 1000 || egid != 1000 {
+ // skip test, cannot create test folder structure with correct ownership
+ return Ok(());
+ }
+
let mut testdir = PathBuf::from("./target/testout");
testdir.push(std::module_path!());
--
2.39.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-06-06 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 8:17 [pbs-devel] [PATCH proxmox-backup 0/2] conditionally skip pxar " Christian Ebner
2024-06-06 8:17 ` [pbs-devel] [PATCH proxmox-backup 1/2] client: pxar: do not attempt to set uid/gid in test Christian Ebner
2024-06-06 8:17 ` Christian Ebner [this message]
2024-06-06 8:54 ` [pbs-devel] applied: [PATCH proxmox-backup 0/2] conditionally skip pxar metadata reference test Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606081711.91531-3-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox