From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/2] client: pxar: do not attempt to set uid/gid in test
Date: Thu, 6 Jun 2024 10:17:10 +0200 [thread overview]
Message-ID: <20240606081711.91531-2-c.ebner@proxmox.com> (raw)
In-Reply-To: <20240606081711.91531-1-c.ebner@proxmox.com>
Setting the uid/gid for the files and folders of the test directory
structure will not work when lacking the permissions.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
pbs-client/src/pxar/create.rs | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs
index fcfb9a09c..d5eb7bd02 100644
--- a/pbs-client/src/pxar/create.rs
+++ b/pbs-client/src/pxar/create.rs
@@ -1814,16 +1814,14 @@ mod tests {
);
let dir_metadata = Metadata {
- stat: pxar::Stat::default().mode(0o777u64).set_dir().gid(0).uid(0),
+ stat: pxar::Stat::default().mode(0o777u64).set_dir(),
..Default::default()
};
let file_metadata = Metadata {
stat: pxar::Stat::default()
.mode(0o777u64)
- .set_regular_file()
- .gid(0)
- .uid(0),
+ .set_regular_file(),
..Default::default()
};
--
2.39.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-06-06 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 8:17 [pbs-devel] [PATCH proxmox-backup 0/2] conditionally skip pxar metadata reference test Christian Ebner
2024-06-06 8:17 ` Christian Ebner [this message]
2024-06-06 8:17 ` [pbs-devel] [PATCH proxmox-backup 2/2] client: pxar: conditionally skip " Christian Ebner
2024-06-06 8:54 ` [pbs-devel] applied: [PATCH proxmox-backup 0/2] conditionally skip pxar " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606081711.91531-2-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox