public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v2 stable-2 pxar proxmox-backup 0/2] backport pxar format version check
Date: Wed,  5 Jun 2024 17:41:53 +0200	[thread overview]
Message-ID: <20240605154155.2365-1-c.ebner@proxmox.com> (raw)

This patches backport the format version entry present in pxar archives
to start with format version 2 and allows to early bail on archives
when an incompatible format version is detected.

changes since version 1:
- adapted to FormatVersion deserializer as present in bumped pxar
  version
- added check to cover also access via Accessor instances
- removed display implementation and adapted bail message
- added additional checks to pxar bin

pxar:

Christian Ebner (1):
  format/decoder/accessor: backport pxar entry type `Version`

 examples/mk-format-hashes.rs |  5 +++++
 src/accessor/mod.rs          | 28 ++++++++++++++++++++++++++--
 src/decoder/mod.rs           | 28 ++++++++++++++++++++++++++--
 src/format/mod.rs            | 19 +++++++++++++++++++
 src/lib.rs                   |  3 +++
 tests/simple/fs.rs           |  1 +
 6 files changed, 80 insertions(+), 4 deletions(-)

proxmox-backup:

Christian Ebner (1):
  client: pxar: bail on incompatible format versions

 pbs-client/src/catalog_shell.rs |  2 +-
 pbs-client/src/pxar/extract.rs  |  3 +++
 pbs-client/src/pxar/tools.rs    | 14 ++++++++------
 pxar-bin/src/main.rs            |  6 +++++-
 4 files changed, 17 insertions(+), 8 deletions(-)

-- 
2.30.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


             reply	other threads:[~2024-06-05 15:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05 15:41 Christian Ebner [this message]
2024-06-05 15:41 ` [pbs-devel] [PATCH v2 stable-2 pxar 1/1] format/decoder/accessor: backport pxar entry type `Version` Christian Ebner
2024-06-06  8:21   ` Fabian Grünbichler
2024-06-06  8:49     ` Christian Ebner
2024-06-06  9:05       ` Fabian Grünbichler
2024-06-05 15:41 ` [pbs-devel] [PATCH v2 stable-2 proxmox-backup 2/2] client: pxar: bail on incompatible format versions Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240605154155.2365-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal