From: Gabriel Goller <g.goller@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH widget-toolkit/proxmox-backup v2 0/5] fix #5463: add optional consent banner before login
Date: Tue, 4 Jun 2024 14:50:03 +0200 [thread overview]
Message-ID: <20240604125014.210321-1-g.goller@proxmox.com> (raw)
The consent text is stored in the node.cfg config file and is encoded
using encodeURI [0] on the frontend. This allows us to support multi-line
strings and special characters. To easily edit the text a new edit-field
called ProxmoxTextAreaField has been introduced. It supports editing and
saving multi-line text and converting it to its URI-encoded representation.
The same implementation will be ported to pve and eventually pmg in
the foreseeable future.
v2, thanks @Thomas, @Dominik:
- remove consent.txt file, move to node.cfg config
- add ui option to insert consent text
- encode text with encodeURI/decodeURI
v1, thanks @Dominik:
- embed consent text into index.html file instead of extra api request
- removed decline button
- added alwaysOnTop property to popup
[0]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURI
widget-toolkit:
Gabriel Goller (2):
window: add consent modal
form: add support for multiline textarea
src/Makefile | 2 ++
src/form/TextAreaField.js | 60 ++++++++++++++++++++++++++++++++++++++
src/grid/ObjectGrid.js | 29 ++++++++++++++++++
src/window/ConsentModal.js | 34 +++++++++++++++++++++
4 files changed, 125 insertions(+)
create mode 100644 src/form/TextAreaField.js
create mode 100644 src/window/ConsentModal.js
backup:
Gabriel Goller (3):
api: add consent api handler and config option
ui: show consent banner before login
docs: add section about consent banner
docs/gui.rst | 7 +++++++
src/api2/node/config.rs | 8 ++++++++
src/bin/proxmox-backup-proxy.rs | 11 ++++++++---
src/config/node.rs | 4 ++++
www/LoginView.js | 9 +++++++++
www/config/NodeOptionView.js | 6 ++++++
www/index.hbs | 1 +
7 files changed, 43 insertions(+), 3 deletions(-)
Summary over all repositories:
11 files changed, 168 insertions(+), 3 deletions(-)
--
Generated by git-murpp 0.5.0
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2024-06-04 12:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 12:50 Gabriel Goller [this message]
2024-06-04 12:50 ` [pbs-devel] [PATCH widget-toolkit v2 1/5] window: add consent modal Gabriel Goller
2024-06-04 12:50 ` [pbs-devel] [PATCH widget-toolkit v2 2/5] form: add support for multiline textarea Gabriel Goller
2024-06-04 12:50 ` [pbs-devel] [PATCH proxmox-backup v2 3/5] api: add consent api handler and config option Gabriel Goller
2024-06-04 12:50 ` [pbs-devel] [PATCH proxmox-backup v2 4/5] ui: show consent banner before login Gabriel Goller
2024-06-04 12:50 ` [pbs-devel] [PATCH proxmox-backup v2 5/5] docs: add section about consent banner Gabriel Goller
2024-06-05 13:22 ` [pbs-devel] [PATCH widget-toolkit/proxmox-backup v2 0/5] fix #5463: add optional consent banner before login Dominik Csapak
2024-06-06 10:18 ` Gabriel Goller
2024-06-06 10:30 ` Dominik Csapak
2024-06-06 11:25 ` Gabriel Goller
2024-06-06 12:09 ` Dominik Csapak
2024-06-06 12:56 ` Gabriel Goller
2024-06-06 13:04 ` Thomas Lamprecht
2024-06-07 8:08 ` Gabriel Goller
2024-06-07 11:48 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604125014.210321-1-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox