* [pbs-devel] [PATCH proxmox-backup] build: fix `nocheck` build
@ 2024-06-03 12:04 Fabian Grünbichler
2024-06-27 7:26 ` [pbs-devel] applied: " Fabian Grünbichler
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Grünbichler @ 2024-06-03 12:04 UTC (permalink / raw)
To: pbs-devel
pbs2to3 was missing from the list of to-be-compiled binaries, and thus was only
compiled as a side-effect of running `cargo test` (which is skipped when the
build is using the `nocheck` build profile).
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
the whole COMPILED_BINS handling seems a bit incomplete, should we also add
pbs2to3 and docgen/dump-catalog-shell-cli to it?
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 03e938767..3e2341864 100644
--- a/Makefile
+++ b/Makefile
@@ -176,6 +176,7 @@ $(COMPILED_BINS) $(COMPILEDIR)/dump-catalog-shell-cli $(COMPILEDIR)/docgen: .do-
--bin proxmox-restore-daemon \
--package proxmox-backup \
--bin docgen \
+ --bin pbs2to3 \
--bin proxmox-backup-api \
--bin proxmox-backup-manager \
--bin proxmox-backup-proxy \
--
2.39.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] build: fix `nocheck` build
2024-06-03 12:04 [pbs-devel] [PATCH proxmox-backup] build: fix `nocheck` build Fabian Grünbichler
@ 2024-06-27 7:26 ` Fabian Grünbichler
0 siblings, 0 replies; 2+ messages in thread
From: Fabian Grünbichler @ 2024-06-27 7:26 UTC (permalink / raw)
To: Proxmox Backup Server development discussion
since I ran into this again..
On June 3, 2024 2:04 pm, Fabian Grünbichler wrote:
> pbs2to3 was missing from the list of to-be-compiled binaries, and thus was only
> compiled as a side-effect of running `cargo test` (which is skipped when the
> build is using the `nocheck` build profile).
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> the whole COMPILED_BINS handling seems a bit incomplete, should we also add
> pbs2to3 and docgen/dump-catalog-shell-cli to it?
>
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 03e938767..3e2341864 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -176,6 +176,7 @@ $(COMPILED_BINS) $(COMPILEDIR)/dump-catalog-shell-cli $(COMPILEDIR)/docgen: .do-
> --bin proxmox-restore-daemon \
> --package proxmox-backup \
> --bin docgen \
> + --bin pbs2to3 \
> --bin proxmox-backup-api \
> --bin proxmox-backup-manager \
> --bin proxmox-backup-proxy \
> --
> 2.39.2
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-27 7:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-03 12:04 [pbs-devel] [PATCH proxmox-backup] build: fix `nocheck` build Fabian Grünbichler
2024-06-27 7:26 ` [pbs-devel] applied: " Fabian Grünbichler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox