Re: [pbs-devel] [PATCH proxmox-backup] fix #5439: disallow creation of datastore in root

[Gabriel Goller <g.goller@proxmox.com>]

On 16.05.2024 12:15, Fabian Grünbichler wrote:
>On May 10, 2024 11:58 am, Gabriel Goller wrote:
>> Creating a datastore in root ('/') works, but afterwards gc fails (can't
>> traverse all directories). It might be sensible to restrict this and
>> disallow creation of datastores in the root directory.
>
>if we do this, we should also forbid it on the frontend side ;)

Yes, we can do that as well.
This will probably be difficult, because AFAIK extjs doesn't support
anything like this out of the box. But creating a custom input field +
listeners to change the style should work.

>I wonder whether we shouldn't handle this in a more generic fashion
>though:
>- disallow path being non-empty (ignoring .zfs ?) -> `/` is not allowed
>  by default
>- unless a flag is set -> in case we forget to handle something, we need
>  an escape hatch
>- if the flag is set, check whether .chunks already exists, and if it
>  does, do not recreate the chunk store
>
>that way, we could also solve the "re-add datastore after re-install"
>issue users are frequently facing..

Wait, what is the issue here?

>obviously, even with that we can explicitly always forbid '/' (before or
>after implementing such a mechanism), since that one is always wrong.

TBH, I don't think there is much to gain from adding all of this.
This is still very much a niche issue IMO, as most user have a separate
disk for datastores, which makes a lot of these issues uncommon.



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel