public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox{, -backup} v3 0/2] Remove influxdb bucket name restrictions
Date: Fri, 26 Apr 2024 16:02:41 +0200	[thread overview]
Message-ID: <20240426140246.168397-1-g.goller@proxmox.com> (raw)

Remove the regex for influxdb organizations and buckets. Influxdb does
not place any constraints on these names and allows all characters. This
also allows influxdb organization names with slashes. Some of these 
characters are not allowed in URI's, that's why we encode them in 
proxmox-metrics.

This also aligns the behavior to PVE as there are no restrictions there
either.

The motivation for this patch is this forum post:
https://forum.proxmox.com/threads/influx-db-organization-doesnt-allow-slash.145402/

v3, thanks @Fabian:
 - encode organization and bucket names

v2, thanks @Thomas:
 - include forum link

proxmox:

Gabriel Goller (1):
  metrics: encode influxdb org and bucket parameters

 proxmox-metrics/Cargo.toml           | 1 +
 proxmox-metrics/src/influxdb/http.rs | 7 ++++++-
 2 files changed, 7 insertions(+), 1 deletion(-)


proxmox-backup:

Gabriel Goller (1):
  api-types: remove influxdb bucket name restrictions

 pbs-api-types/src/metrics.rs | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)


Summary over all repositories:
  3 files changed, 9 insertions(+), 4 deletions(-)

-- 
Generated by git-murpp 0.5.0


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


             reply	other threads:[~2024-04-26 14:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-26 14:02 Gabriel Goller [this message]
2024-04-26 14:02 ` [pbs-devel] [PATCH proxmox v3 1/2] metrics: encode influxdb org and bucket parameters Gabriel Goller
2024-04-26 15:52   ` [pbs-devel] applied: " Thomas Lamprecht
2024-04-30 10:11     ` Gabriel Goller
2024-04-26 14:02 ` [pbs-devel] [PATCH proxmox-backup v3 2/2] api-types: remove influxdb bucket name restrictions Gabriel Goller
2024-04-26 15:57   ` [pbs-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240426140246.168397-1-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal