[pbs-devel] [PATCH proxmox-backup 1/2] ui: datastore add: validate if path is absolute

[pbs-devel] [PATCH proxmox-backup 1/2] ui: datastore add: validate if path is absolute

[Dominik Csapak]

the backend checks this too, but by then we closed the window already
and the user has to start adding again.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/window/DataStoreEdit.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/window/DataStoreEdit.js b/www/window/DataStoreEdit.js
index b61154606..4d4c528f3 100644
--- a/www/window/DataStoreEdit.js
+++ b/www/window/DataStoreEdit.js
@@ -61,6 +61,7 @@ Ext.define('PBS.DataStoreEdit', {
 			allowBlank: false,
 			fieldLabel: gettext('Backing Path'),
 			emptyText: gettext('An absolute path'),
+			validator: v => v.startsWith('/') ? true : gettext('Path must be absolute.'),
 		    },
 		],
 		column2: [
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox-backup 2/2] ui: prune jobs: add enabled column in grid

[Dominik Csapak]

so one can see if the jobs are enabled or disabled

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
alternatively we could override the render for the schedule itself,
to either show '-' like we do for all other jobs that are disabled by
removing the schedule, or add smthg like `(disabled)` to the schedule

though what this patch does is the same we have for backup jobs in pve

 www/config/PruneView.js | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/www/config/PruneView.js b/www/config/PruneView.js
index 94bb7dd61..d4b0841d4 100644
--- a/www/config/PruneView.js
+++ b/www/config/PruneView.js
@@ -14,6 +14,10 @@ Ext.define('pbs-prune-jobs-status', {
 	    },
 	},
 	'comment',
+	{
+	    name: 'enabled',
+	    calculate: data => !data.disable,
+	},
     ],
     idProperty: 'id',
     proxy: {
@@ -171,6 +175,14 @@ Ext.define('PBS.config.PruneJobView', {
     },
 
     columns: [
+	{
+	    header: gettext('Enabled'),
+	    width: 80,
+	    dataIndex: 'enabled',
+	    align: 'center',
+	    renderer: Proxmox.Utils.renderEnabledIcon,
+	    sortable: true,
+	},
 	{
 	    header: gettext('Job ID'),
 	    dataIndex: 'id',
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel