From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH widget-toolkit 1/2] realm edit: don't send type as extra parameter when 'useTypeInUrl' is set
Date: Thu, 25 Apr 2024 11:32:33 +0200 [thread overview]
Message-ID: <20240425093234.2192162-1-d.csapak@proxmox.com> (raw)
in that case, the type is already part of the url and we must not send
it additionally as an parameter
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/window/AuthEditBase.js | 2 ++
src/window/AuthEditLDAP.js | 2 +-
src/window/AuthEditOpenId.js | 2 +-
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/window/AuthEditBase.js b/src/window/AuthEditBase.js
index 43a2fd6..0f272e6 100644
--- a/src/window/AuthEditBase.js
+++ b/src/window/AuthEditBase.js
@@ -51,6 +51,7 @@ Ext.define('Proxmox.window.AuthEditBase', {
realm: me.realm,
xtype: authConfig.ipanel,
isCreate: me.isCreate,
+ useTypeInUrl: me.useTypeInUrl,
type: me.authType,
},
{
@@ -67,6 +68,7 @@ Ext.define('Proxmox.window.AuthEditBase', {
realm: me.realm,
xtype: authConfig.ipanel,
isCreate: me.isCreate,
+ useTypeInUrl: me.useTypeInUrl,
type: me.authType,
}];
}
diff --git a/src/window/AuthEditLDAP.js b/src/window/AuthEditLDAP.js
index da83520..f6f7fe0 100644
--- a/src/window/AuthEditLDAP.js
+++ b/src/window/AuthEditLDAP.js
@@ -32,7 +32,7 @@ Ext.define('Proxmox.panel.LDAPInputPanel', {
onlineHelp: 'user-realms-ldap',
onGetValues: function(values) {
- if (this.isCreate) {
+ if (this.isCreate && !this.useTypeInUrl) {
values.type = this.type;
}
diff --git a/src/window/AuthEditOpenId.js b/src/window/AuthEditOpenId.js
index ca84958..08ced99 100644
--- a/src/window/AuthEditOpenId.js
+++ b/src/window/AuthEditOpenId.js
@@ -8,7 +8,7 @@ Ext.define('Proxmox.panel.OpenIDInputPanel', {
onGetValues: function(values) {
let me = this;
- if (me.isCreate) {
+ if (me.isCreate && !me.useTypeInUrl) {
values.type = me.type;
}
--
2.39.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2024-04-25 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 9:32 Dominik Csapak [this message]
2024-04-25 9:32 ` [pbs-devel] [PATCH widget-toolkit 2/2] realm edit: don't send 'delete' parameter when creating new entry Dominik Csapak
2024-04-25 9:43 ` [pbs-devel] applied-series: [PATCH widget-toolkit 1/2] realm edit: don't send type as extra parameter when 'useTypeInUrl' is set Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425093234.2192162-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox