From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 3/4] ui: don't re-calculate GC duration
Date: Mon, 22 Apr 2024 13:38:33 +0200 [thread overview]
Message-ID: <20240422113834.842169-4-f.gruenbichler@proxmox.com> (raw)
In-Reply-To: <20240422113834.842169-1-f.gruenbichler@proxmox.com>
it is returned by the API anyway
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
www/config/GCView.js | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/www/config/GCView.js b/www/config/GCView.js
index 982ab939..bcea72a5 100644
--- a/www/config/GCView.js
+++ b/www/config/GCView.js
@@ -2,16 +2,7 @@ Ext.define('pbs-gc-jobs-status', {
extend: 'Ext.data.Model',
fields: [
'store', 'upid', 'removed-bytes', 'pending-bytes', 'schedule',
- 'next-run', 'last-run-endtime', 'last-run-state',
- {
- name: 'duration',
- calculate: function(data) {
- let endtime = data['last-run-endtime'];
- if (!endtime) return undefined;
- let task = Proxmox.Utils.parse_task_upid(data['upid']);
- return endtime - task.starttime;
- },
- },
+ 'next-run', 'last-run-endtime', 'last-run-state', 'duration',
],
idProperty: 'store',
proxy: {
--
2.39.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-04-22 11:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 11:05 [pbs-devel] [PATCH proxmox-backup 0/3] follow ups for gc job status series Dominik Csapak
2024-04-22 11:05 ` [pbs-devel] [PATCH proxmox-backup 1/3] ui: gc view: use beforedestroy for stopping the store Dominik Csapak
2024-04-22 11:05 ` [pbs-devel] [PATCH proxmox-backup 2/3] ui: prune/gc view: improve sizing & scrolling behaviour Dominik Csapak
2024-04-22 11:05 ` [pbs-devel] [PATCH proxmox-backup 3/3] ui: gc view: remove unnecessary widths in columns Dominik Csapak
2024-04-22 11:38 ` [pbs-devel] [PATCH proxmox-backup 0/4] more follow-ups Fabian Grünbichler
2024-04-22 11:38 ` [pbs-devel] [PATCH proxmox-backup 1/4] GC: flatten existing status into job status Fabian Grünbichler
2024-04-22 11:38 ` [pbs-devel] [PATCH proxmox-backup 2/4] api: merge garbage-collection-status and -job-status Fabian Grünbichler
2024-04-22 11:38 ` Fabian Grünbichler [this message]
2024-04-22 11:38 ` [pbs-devel] [PATCH proxmox-backup 4/4] GC status: reduce code duplication Fabian Grünbichler
2024-04-23 12:36 ` [pbs-devel] applied: [PATCH proxmox-backup 0/3] follow ups for gc job status series Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422113834.842169-4-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox