[pbs-devel] [PATCH proxmox-backup] ui: fix layout reset

[pbs-devel] [PATCH proxmox-backup] ui: fix layout reset

[Dominik Csapak]

we have to iterate over the keys of the state object here, not over the
values. This meant one could not reset the layout from the settings
window.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/window/Settings.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/window/Settings.js b/www/window/Settings.js
index 763cefab..c785dd88 100644
--- a/www/window/Settings.js
+++ b/www/window/Settings.js
@@ -96,7 +96,7 @@ Ext.define('PBS.window.Settings', {
 		click: function() {
 		    let blacklist = ['login-username'];
 		    let sp = Ext.state.Manager.getProvider();
-		    for (const state of Object.values(sp.state)) {
+		    for (const state of Object.keys(sp.state)) {
 			if (blacklist.indexOf(state) !== -1) {
 			    continue;
 			}
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox-backup] ui: fix layout reset

[Fabian Grünbichler]

thanks!

On April 22, 2024 1:06 pm, Dominik Csapak wrote:
> we have to iterate over the keys of the state object here, not over the
> values. This meant one could not reset the layout from the settings
> window.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/window/Settings.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/window/Settings.js b/www/window/Settings.js
> index 763cefab..c785dd88 100644
> --- a/www/window/Settings.js
> +++ b/www/window/Settings.js
> @@ -96,7 +96,7 @@ Ext.define('PBS.window.Settings', {
>  		click: function() {
>  		    let blacklist = ['login-username'];
>  		    let sp = Ext.state.Manager.getProvider();
> -		    for (const state of Object.values(sp.state)) {
> +		    for (const state of Object.keys(sp.state)) {
>  			if (blacklist.indexOf(state) !== -1) {
>  			    continue;
>  			}
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel